Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix icon issue on ios and manifest on android #1294

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Fix icon issue on ios and manifest on android #1294

merged 1 commit into from
Feb 28, 2019

Conversation

iskakaushik
Copy link
Contributor

No description provided.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For future changes - better to keep each fix in a separate PR, other than being easier to review, if we need to roll back one of the fixes we don't need to roll back the other as well, or if CI is failing we know which fix is the culprit immediately.

@iskakaushik iskakaushik merged commit ac84635 into flutter:master Feb 28, 2019
@iskakaushik iskakaushik deleted the bugfix/maps-icon-ios branch February 28, 2019 17:41
@@ -8,7 +8,8 @@
android:name="io.flutter.app.FlutterApplication"
android:label="google_maps_flutter_example"
android:icon="@mipmap/ic_launcher">
<meta-data
<uses-library android:name="org.apache.http.legacy" android:required="false"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the plugin's manifest, should we?
What if we want to use maps in an app that needs this to be false?

romaluca pushed a commit to romaluca/plugins that referenced this pull request Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants