-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[connectivity] Enable fetching current Wi-Fi network's BSSID #1331
Conversation
I also created a helper method findNetworkInfo to reduce code duplication for getting the BSSID and SSID of the current network.
I also created a helper method getWifiInfo to reduce code duplication for getting the BSSID and SSID of the current network.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I'm not sure why |
/// Please note that it DOESN'T WORK on emulators (returns null). | ||
/// | ||
/// From android 8.0 onwards the GPS must be ON (high accuracy) | ||
/// in order to be able to obtain the SSID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSID -> BSSID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed it: 8033d9e
Is there something else I should fix? |
Thanks for contributing! To keep the plugins repository scalable we should try to not introduce new features without e2e tests. I'm marking this PR as waiting for test harness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing this PR. The changes look good. We require any new features added to the plugin to have test driver tests. I have created a PR to set up test driver on this plugin. https://github.com/flutter/plugins/pull/1455/files
Could you wait until the PR landed and adding a test for your change? If you don't have time to continue working on this, we can shepherd it from here.
For more details on test driver test, you can refer to https://flutter.dev/docs/cookbook/testing/integration/introduction and our contribution guide here https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md
Based on cyanglaz's suggestion in PR #1331 Co-Authored-By: vargavince91 <vargavince91@gmail.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I can resolve the conflicts and add the driver tests this week (though not sure which day). |
@cyanglaz I added tests and resolved conflicts, can I get your lgtm to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one little thing in the test code.
…#1331) Add getWifiBSSID method
Usage: