Add Shared Preferences plugin #16

collinjackson · 2017-05-03T23:08:55Z

eseidelGoogle · 2017-05-03T23:10:19Z

packages/shared-preferences/android/build.gradle

@@ -0,0 +1,32 @@
+group 'com.yourcompany.shared_preferences'


Is this correct?

eseidelGoogle · 2017-05-03T23:10:40Z

packages/shared-preferences/android/src/main/AndroidManifest.xml

@@ -0,0 +1,7 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  package="com.yourcompany.shared_preferences"


probably io.flutter here?

szakarias

Cool stuff!

szakarias · 2017-05-04T08:04:18Z

packages/shared-preferences/example/android/app/src/main/AndroidManifest.xml

@@ -0,0 +1,32 @@
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.yourcompany.shared_preferences_example"


Probably you want "io.flutter.plugins" here.

szakarias · 2017-05-04T08:06:25Z

packages/shared-preferences/example/ios/Runner/AppDelegate.m

+  plugins = [[PluginRegistry alloc] initWithController:flutterController];
+  return YES;
+}
+


Consider deleting the methods below.

This file is the unmodified output of flutter create, I think it's better not to customize it since that isn't part of the plugin installation instructions.

szakarias · 2017-05-04T08:08:23Z

packages/shared-preferences/example/lib/main.dart

@@ -0,0 +1,65 @@
+import 'dart:async';


Missing copyright

szakarias · 2017-05-04T08:12:39Z

packages/shared-preferences/example/pubspec.yaml

+  shared_preferences:
+    path: ../
+
+# For information on the generic Dart part of this file, see the


Consider removing the generated comments.

szakarias · 2017-05-04T08:14:08Z

packages/shared-preferences/example/ios/Runner/AppDelegate.m

@@ -0,0 +1,38 @@
+#include "AppDelegate.h"
+#include "PluginRegistry.h"
+


You might want a copyright statement here.

This file is the unmodified output of flutter create

szakarias · 2017-05-04T08:23:43Z

packages/shared-preferences/example/lib/main.dart

+        child: new FutureBuilder(
+          future: _prefs,
+          builder: (BuildContext context, AsyncSnapshot<SharedPreferences> snapshot) {
+            if (snapshot.connectionState != ConnectionState.done)


This could also be ' if (snapshot.connectionState == ConnectionsState.waiting)

szakarias · 2017-05-04T08:24:57Z

packages/shared-preferences/example/lib/main.dart

+          future: _prefs,
+          builder: (BuildContext context, AsyncSnapshot<SharedPreferences> snapshot) {
+            if (snapshot.connectionState != ConnectionState.done)
+              return new Text('Loading...');


perhaps const Text() here and in the title ?

szakarias · 2017-05-04T08:28:32Z

Consider adding a CHANGELOG.md

mit-mit

Reviewed just the readme.md files, looks good.

Thanks for adding this plugin!

xster · 2017-05-04T22:44:51Z

packages/shared-preferences/ios/shared_preferences.podspec

+  s.name             = 'shared_preferences'
+  s.version          = '0.0.1'
+  s.summary          = 'A new flutter plugin project.'
+  s.description      = <<-DESC


May not matter since you're hosting them separately but might look more complete if you filled these

I think we have agreed not to maintain this. We only have it to make CocoaPods happy.

I'll leave it as-is for now but feel free to change it

collinjackson · 2017-05-05T17:21:54Z

Thanks for the comments

FAILURE: Build failed with an exception. * Where: Build file 'C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\build.gradle' line: 22 * What went wrong: A problem occurred evaluating root project 'shared_preferences_macos'. > Failed to apply plugin [id 'com.android.library'] > Minimum supported Gradle version is 5.4.1. Current version is 5.1.1. If using the gradle wrapper, try editing the distributionUrl in C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\gradle\wrapper\gradle-wrapper.properties to gradle-5.4.1-all.zip * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 1s [ +1 ms] Running Gradle task 'assembleAarRelease'... (completed in 2,0s) [ ] FAILURE: Build failed with an exception. * Where: Build file 'C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\build.gradle' line: 22 * What went wrong: A problem occurred evaluating root project 'shared_preferences_macos'. > Failed to apply plugin [id 'com.android.library'] > Minimum supported Gradle version is 5.4.1. Current version is 5.1.1. If using the gradle wrapper, try editing the distributionUrl in C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\gradle\wrapper\gradle-wrapper.properties to gradle-5.4.1-all.zip * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 1s [ +5 ms] "flutter apk" took 179.497ms. The plugin shared_preferences_macos could not be built due to the issue above. #0 throwToolExit (package:flutter_tools/src/base/common.dart:28:3) flutter#1 buildPluginsAsAar (package:flutter_tools/src/android/gradle.dart:726:7) flutter#2 _asyncErrorWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:80:45) #3 _rootRunBinary (dart:async/zone.dart:1146:38) flutter#4 _CustomZone.runBinary (dart:async/zone.dart:1039:19) flutter#5 _FutureListener.handleError (dart:async/future_impl.dart:153:20) flutter#6 Future._propagateToListeners.handleError (dart:async/future_impl.dart:692:47) flutter#7 Future._propagateToListeners (dart:async/future_impl.dart:713:24) flutter#8 Future._completeError (dart:async/future_impl.dart:532:5) flutter#9 _AsyncAwaitCompleter.completeError (dart:async-patch/async_patch.dart:38:15) flutter#10 buildGradleAar (package:flutter_tools/src/android/gradle.dart) flutter#11 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64) flutter#12 _rootRunUnary (dart:async/zone.dart:1134:38) flutter#13 _CustomZone.runUnary (dart:async/zone.dart:1031:19) flutter#14 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) flutter#15 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) flutter#16 Future._propagateToListeners (dart:async/future_impl.dart:709:32) #17 Future._completeWithValue (dart:async/future_impl.dart:524:5) flutter#18 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:32:15) flutter#19 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:290:13) flutter#20 _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart) flutter#21 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64) flutter#22 _rootRunUnary (dart:async/zone.dart:1134:38) flutter#23 _CustomZone.runUnary (dart:async/zone.dart:1031:19) flutter#24 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) flutter#25 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) flutter#26 Future._propagateToListeners (dart:async/future_impl.dart:709:32) flutter#27 Future._completeWithValue (dart:async/future_impl.dart:524:5) flutter#28 Future.wait.<anonymous closure> (dart:async/future.dart:400:22) flutter#29 _rootRunUnary (dart:async/zone.dart:1134:38) flutter#30 _CustomZone.runUnary (dart:async/zone.dart:1031:19) flutter#31 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) flutter#32 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) flutter#33 Future._propagateToListeners (dart:async/future_impl.dart:709:32) flutter#34 Future._completeWithValue (dart:async/future_impl.dart:524:5) flutter#35 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7) flutter#36 _rootRun (dart:async/zone.dart:1126:13) flutter#37 _CustomZone.run (dart:async/zone.dart:1023:19) flutter#38 _CustomZone.runGuarded (dart:async/zone.dart:925:7) flutter#39 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23) flutter#40 _microtaskLoop (dart:async/schedule_microtask.dart:43:21) flutter#41 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5) flutter#42 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13) flutter#43 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)

…onboundries-feature Added test coverage to region boundaries feature

collinjackson force-pushed the shared_preferences branch from 90580d4 to 27d0740 Compare May 3, 2017 23:09

eseidelGoogle reviewed May 3, 2017

View reviewed changes

collinjackson force-pushed the shared_preferences branch from 27d0740 to 465b619 Compare May 3, 2017 23:14

collinjackson changed the title ~~Add Shared Preferences plugin. Fixes flutter/flutter#4757~~ Add Shared Preferences plugin May 3, 2017

collinjackson force-pushed the shared_preferences branch from 465b619 to ea8a20e Compare May 3, 2017 23:23

collinjackson requested a review from mit-mit May 3, 2017 23:24

mit-mit requested a review from szakarias May 4, 2017 08:17

szakarias reviewed May 4, 2017

View reviewed changes

mit-mit reviewed May 4, 2017

View reviewed changes

xster reviewed May 4, 2017

View reviewed changes

Add Shared Preferences plugin.

a832977

collinjackson force-pushed the shared_preferences branch from ea8a20e to e5a9d39 Compare May 5, 2017 17:13

Implement review feedback

d7d4c77

collinjackson force-pushed the shared_preferences branch from e5a9d39 to d7d4c77 Compare May 5, 2017 17:21

collinjackson merged commit d238a53 into flutter:master May 5, 2017

This was referenced Dec 6, 2019

Fix:avoid calling setState() when mounted is false. #2360

Closed

[Sensors] Fix:avoid calling setState() when mounted is false. #2361

Closed

srburton mentioned this pull request Feb 21, 2020

[FIX] - Gradle #2546

Closed

13 tasks

nt4f04uNd pushed a commit to nt4f04uNd/plugins that referenced this pull request Mar 23, 2021

Merge pull request flutter#16 from bottlepay/android-rework-test-regi…

5b67428

…onboundries-feature Added test coverage to region boundaries feature

		@@ -0,0 +1,7 @@
		<manifest xmlns:android="http://schemas.android.com/apk/res/android"
		package="com.yourcompany.shared_preferences"

		@@ -0,0 +1,32 @@
		<manifest xmlns:android="http://schemas.android.com/apk/res/android"
		package="com.yourcompany.shared_preferences_example"

		@@ -0,0 +1,38 @@
		#include "AppDelegate.h"
		#include "PluginRegistry.h"

Add Shared Preferences plugin #16

Add Shared Preferences plugin #16

Uh oh!

Conversation

collinjackson commented May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szakarias left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

collinjackson May 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szakarias commented May 4, 2017

Uh oh!

mit-mit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

collinjackson commented May 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

collinjackson commented May 3, 2017 •

edited

Loading

collinjackson May 5, 2017 •

edited

Loading