Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] [WIP] Add web implementation #2041

Closed
wants to merge 1 commit into from

Conversation

cbenhagen
Copy link
Contributor

@cbenhagen cbenhagen commented Sep 4, 2019

Description

This is adding a web plugin for video_player using HtmlElementView and a generated plugin registrant.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cbenhagen cbenhagen force-pushed the video_player_web branch 2 times, most recently from fd2d2f5 to 662e21a Compare September 4, 2019 21:43
@cbenhagen cbenhagen changed the title [video_player] [WIP] Add web plugin [video_player] [WIP] Add web implementation Sep 4, 2019
@cbenhagen cbenhagen force-pushed the video_player_web branch 2 times, most recently from aedc85b to 114f346 Compare September 5, 2019 10:08
@cyanglaz cyanglaz added the WIP label Sep 23, 2019
@MateusAmin
Copy link

Thanks for working on this @cbenhagen :D

androidPackage: io.flutter.plugins.videoplayer
iosPrefix: FLT
pluginClass: VideoPlayerPlugin
platforms:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't land this before next stable release as the plugin won't compile with the stable tool.

@amirh
Copy link
Contributor

amirh commented Oct 15, 2019

This should be implemented as a federated package (see: https://flutter.dev/go/federated-plugins).

I think this plugin needs a refactoring to have a Dart platform interface before adding the web implementation.

cc @hterkelsen

@cbenhagen
Copy link
Contributor Author

@amirh / @hterkelsen I feel a bit lost adding that platform interface and especially in adding the needed tests. Would you be able to provide some guidance / mentoring?

@harryterkelsen
Copy link
Contributor

Hi Ben, I'm happy to help! To get you started, you can take a look at the changes I made to url_launcher to add a platform interface:

Please don't hesitate to ask if you have any questions

@cbenhagen
Copy link
Contributor Author

cbenhagen commented Nov 13, 2019

@hterkelsen I used your changes as a template and opened #2273 and #2276.

Is there an advantage in using method channels for the web plugins? Or should I just implement a WebVideoPlayer which does not use them?

@cbenhagen
Copy link
Contributor Author

Closing in favor of #2279

@cbenhagen cbenhagen closed this Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants