-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[video_player] [WIP] Add web implementation #2041
Conversation
fd2d2f5
to
662e21a
Compare
aedc85b
to
114f346
Compare
114f346
to
9c981b3
Compare
2318dcc
to
3a3c13e
Compare
3a3c13e
to
beccb7d
Compare
Thanks for working on this @cbenhagen :D |
androidPackage: io.flutter.plugins.videoplayer | ||
iosPrefix: FLT | ||
pluginClass: VideoPlayerPlugin | ||
platforms: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't land this before next stable release as the plugin won't compile with the stable tool.
This should be implemented as a federated package (see: https://flutter.dev/go/federated-plugins). I think this plugin needs a refactoring to have a Dart platform interface before adding the web implementation. cc @hterkelsen |
@amirh / @hterkelsen I feel a bit lost adding that platform interface and especially in adding the needed tests. Would you be able to provide some guidance / mentoring? |
Hi Ben, I'm happy to help! To get you started, you can take a look at the changes I made to
Please don't hesitate to ask if you have any questions |
@hterkelsen I used your changes as a template and opened #2273 and #2276. Is there an advantage in using method channels for the web plugins? Or should I just implement a WebVideoPlayer which does not use them? |
Closing in favor of #2279 |
Description
This is adding a web plugin for video_player using
HtmlElementView
and a generated plugin registrant.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?