Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[all] Switch to pedantic lint package #2258

Closed
wants to merge 1 commit into from
Closed

[all] Switch to pedantic lint package #2258

wants to merge 1 commit into from

Conversation

mklim
Copy link
Contributor

@mklim mklim commented Nov 7, 2019

Description

Our analysis_options.yaml was supposed to be a mirror of
flutter/flutter but had fallen out of date. This will be an easier way
to keep it standardized and synced.

This also required fixing all the lint errors brought in by that lint
package. Most of them were missing awaits.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Our `analysis_options.yaml` was supposed to be a mirror of
flutter/flutter but had fallen out of date. This will be an easier way
to keep it standardized and synced.

This also required fixing all the lint errors brought in by that lint
package. Most of them were missing `await`s.
@sarbagyastha
Copy link
Contributor

sarbagyastha commented Nov 8, 2019

Since, pedantic is only used for analysis_options.yaml, isn't it best to set it as dev_dependency, expect for package_info?

@mklim
Copy link
Contributor Author

mklim commented Nov 8, 2019

@sarbagyastha yeah, good catch. This PR is still just a work in progress, there's some more things I'd like to fix here before landing it.

@mklim
Copy link
Contributor Author

mklim commented Nov 23, 2019

I'm closing this for now in favor of a more gradual approach, #2300. I don't think it's practical to try to add and fix all these new rules at once.

@mklim mklim closed this Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants