This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[local_auth] support v2 embedding #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
bparrishMines
commented
Dec 12, 2019
| @@ -11,6 +11,7 @@ source "$SCRIPT_DIR/common.sh" | |||
| check_changed_packages > /dev/null | |||
|
|
|||
| readonly EXCLUDED_PLUGINS_LIST=( | |||
| "flutter_plugin_android_lifecycle" | |||
There was a problem hiding this comment.
Adding this to the exclude list because the all plugins app creates a local dependency while this plugin creates a hosted dependency. This caused errors at compilation.
|
I am confused about this PR. The lifecycle adapter does not exist in master either: https://github.com/flutter/engine/tree/master/shell/platform/android/io/flutter/embedding/engine/plugins/lifecycle. |
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#41841
Tests fail on stable untilFlutterLifecycleAdapterlands in stable.