Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player_web] add a no-op android folder #2408

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Dec 12, 2019

Description

Adding an android/ folder as a temporary mitigation for:

flutter/flutter#46304
flutter/flutter#46790

Related Issues

flutter/flutter#46898

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,8 @@
*.iml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This can be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping the template list as the easy choice, FWIW someone may decide to open this project with Android Studio...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our root .gitignore would still be applied here in that case, since AS should be deferring to git which would be able to tell that this is part of a larger repo. But either way it's fine to keep this if you'd prefer, it's not doing any harm and matches the template.

@amirh amirh merged commit 6cce7b6 into flutter:master Dec 12, 2019
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Adding an android/ folder as a temporary mitigation for: flutter/flutter#46898
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants