This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[google_sign_in_web] Add a no-op Android implementation #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
reviewed
Dec 12, 2019
| public class GoogleSignInWebPlugin implements FlutterPlugin, MethodCallHandler { | ||
| @Override | ||
| public void onAttachedToEngine(FlutterPluginBinding flutterPluginBinding) { | ||
| final MethodChannel channel = new MethodChannel(flutterPluginBinding.getFlutterEngine().getDartExecutor(), "google_sign_in_web"); |
There was a problem hiding this comment.
nit: delete the implementation
| import io.flutter.plugin.common.PluginRegistry.Registrar; | ||
|
|
||
| /** GoogleSignInWebPlugin */ | ||
| public class GoogleSignInWebPlugin implements FlutterPlugin, MethodCallHandler { |
There was a problem hiding this comment.
nit: this doesn't need to extend MethodCallHandler (delete onMethodCall)
added 2 commits
December 12, 2019 14:55
harryterkelsen
approved these changes
Dec 12, 2019
|
@mklim since you touched on google sigin package, can you please have a look at flutter/flutter#41296 It is quite unusable without it, and hope it is a quick change for you. There was a pr about to merge and hope that help to. thanks. |
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
flutter/flutter#46898
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?