-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] fix swift example in readme #2428
Conversation
Please review this small docs fix |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
If anyone is requested for review -- please sorry, I've just pushed commits merged from master by accident. It made it because I wanted to PR for flutter/flutter#48906 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. please update pubspec and changelog with a new version. Thank you!
Done. Version was updated in #2042 (wasn't published yet) |
@cyanglaz should I do anything else? |
@PiN73 Thanks. Sorry about the "not publishing". I just published the new version, could you please update your PR again with a new version? |
No problem, done. |
Description
This PR replaces
UIApplicationLaunchOptionsKey
withUIApplication.LaunchOptionsKey
in example for swift because first one doesn't longer work due to flutter/flutter#35763Related Issues
Here is a description of compile error which occurs when using
UIApplicationLaunchOptionsKey
:https://stackoverflow.com/questions/59365426/flutter-google-maps-ios-build-fail