Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] fix swift example in readme #2428

Merged
merged 5 commits into from
Jan 28, 2020
Merged

[google_maps_flutter] fix swift example in readme #2428

merged 5 commits into from
Jan 28, 2020

Conversation

PiN73
Copy link
Contributor

@PiN73 PiN73 commented Dec 17, 2019

Description

This PR replaces UIApplicationLaunchOptionsKey with UIApplication.LaunchOptionsKey in example for swift because first one doesn't longer work due to flutter/flutter#35763

Related Issues

Here is a description of compile error which occurs when using UIApplicationLaunchOptionsKey:
https://stackoverflow.com/questions/59365426/flutter-google-maps-ios-build-fail

@PiN73
Copy link
Contributor Author

PiN73 commented Jan 15, 2020

Please review this small docs fix

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@PiN73
Copy link
Contributor Author

PiN73 commented Jan 15, 2020

If anyone is requested for review -- please sorry, I've just pushed commits merged from master by accident.

It made it because I wanted to PR for flutter/flutter#48906

@bkonyi bkonyi removed their request for review January 15, 2020 18:28
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please update pubspec and changelog with a new version. Thank you!

@cyanglaz cyanglaz added the submit queue The Flutter team is in the process of landing this PR. label Jan 23, 2020
@PiN73
Copy link
Contributor Author

PiN73 commented Jan 23, 2020

Done. Version was updated in #2042 (wasn't published yet)

@PiN73
Copy link
Contributor Author

PiN73 commented Jan 27, 2020

@cyanglaz should I do anything else?

@cyanglaz
Copy link
Contributor

@PiN73 Thanks. Sorry about the "not publishing". I just published the new version, could you please update your PR again with a new version?

@PiN73
Copy link
Contributor Author

PiN73 commented Jan 28, 2020

No problem, done.

@cyanglaz cyanglaz merged commit 569a5b7 into flutter:master Jan 28, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants