[android_alarm_manager] Fixed issue where callback lookup was failing in the background #2453
Conversation
the background If callback lookup was attempted before Flutter was initialized, the callback cache would not yet be populated resulting in a failed callback lookup.
There was a problem hiding this comment.
Any way to test this? I get that this is inherently kind of tricky to try and e2e test since it needs to be backgrounded at some point. Would it be possible to unit test FlutterBAckgroundExecutor#startBackgroundIsolate? All PRs need to have automated tests before we can merge them into the tree, see Tree Hygiene #4.
I honestly wouldn't know how to go about doing that since my Android testing experience is non-existent. We'd need to be able to run the application in the foreground once to initialize state, kill it, and then wait for it to come up. |
|
@bkonyi I typed up a long comment explaining how to write Java unit tests in our repo, looked at the method more closely, and then realized that it's doing way too much work with JNI and global static state to be really unit tested anyway. Disregard that suggestion. :)
I think we could potentially do this in a Dart e2e test. Check out camera_e2e_test.dart, where we use adb from the test runner to grant the test app permissions before it runs. What if we killed the test app with |
Hm... I think that would work. Let me hack something together and give it a shot. |
|
You know, the thing that would be really good to test is whether it comes back after a reboot. I don't suppose we can reboot the phone as well during the test? :-) |
There was a problem hiding this comment.
LGTM
Discussed offline, we don't quite have the capabilities to test this yet, but we should be able to once we have better support for android integration tests. We've got an exemption to land this as-is with a TODO to test it once we have the capability (flutter/flutter#38983).
|
Filed an issue to add tests when possible: flutter/flutter#48439 |
… in the background (flutter#2453) If callback lookup was attempted before Flutter was initialized, the callback cache would not yet be populated resulting in a failed callback lookup.
If callback lookup was attempted before Flutter was initialized, the callback cache would not yet be populated resulting in a failed callback lookup.
Fixes flutter/flutter#47406