This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] always make sure the contentInset or the sum of contentInset and adjustedContentInset is 0 on iOS. #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
changed the title
added 3 commits
January 13, 2020 17:00
amirh
reviewed
Jan 15, 2020
| FLTWKWebView *webView = [[FLTWKWebView alloc] initWithFrame:CGRectMake(0, 0, 300, 400)]; | ||
| webView.scrollView.contentInset = UIEdgeInsetsMake(0, 0, 300, 0); | ||
| XCTAssertFalse(UIEdgeInsetsEqualToEdgeInsets(webView.scrollView.contentInset, UIEdgeInsetsZero)); | ||
| webView.frame = CGRectMake(0, 0, 300, 200); |
There was a problem hiding this comment.
Lets also assert that the frame was updated, as we are overriding the setter.
| webView.frame = CGRectMake(0, 0, 300, 200); | ||
| XCTAssertTrue(UIEdgeInsetsEqualToEdgeInsets(webView.scrollView.contentInset, UIEdgeInsetsZero)); | ||
|
|
||
| if (@available(iOS 11, *)) { |
There was a problem hiding this comment.
What's the effect of such a condition on a XCTest, are we running once with iOS < 11 and once with iOS >= 11?
There was a problem hiding this comment.
our ci is currently running on the latest iOS (13), I added this condition in case we decided to run CI for a lower iOS version. In a lower version, since there is no adjustedContentInset, we don't need to test it.
| @@ -21,4 +21,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| - (instancetype)initWithMessenger:(NSObject<FlutterBinaryMessenger>*)messenger; | |||
| @end | |||
|
|
|||
| @interface FLTWKWebView : WKWebView | |||
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…tentInset and adjustedContentInset is 0 on iOS. (flutter#2466)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IOS sometimes updates the contentInset of the scroll view (for example to incorporate the keyboard) when the frame of the WebView changes.
The contentInset of the scrollview should be reverted to 0 after changing the view's frame so it doesn't interfere with Flutter.
This PR also fixes the XCTest test cases to follow XCTest's naming conventions.
Related Issues
Fixes flutter/flutter#45482
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?