-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
Actions picks configs from |
@fkorotkov I just submitted a new PR to test this, it seems like something isn't configured properly: https://github.com/flutter/plugins/pull/2493/checks?check_run_id=424083286
|
Damn, it seems it's failing because the PR comes from a fork and the action is authorized with permissions of a fork which can't update status checks. Seems it's a limitation that can't be workarounded and we'll need to incorporate the logic in Cirrus or a separate GitHub App. For now it seems we can keep triggering the action on |
Bummer. Only updating when a commit is merged to master will deadlock the branch once it's red won't it? Should I revert this PR for now? |
Yeah, once a branch is red your'll need to merge though the red |
This reverts commit bc69693.
This reverts commit bc69693.
This reverts commit bc69693.
Description
This should add a presubmit that's block PR from landing while the tree is red.
Related Issues
flutter/flutter#28921