This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Remove deprecations #2737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zazo032
commented
May 6, 2020
Comment on lines
-92
to
+97
| headersMap.put(key, value); | ||
| if (value != null) { | ||
| headersMap.put(key, value); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Android Studio suggested this change as value may not be initialized.
Contributor
|
@Zazo032 |
Contributor
Author
|
Fixed by @mvanbeusekom on #3008 |
Contributor
|
finally? |
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed Android deprecation warnings by adding
@SuppressWarningsto deprecated method, and@RequireApito the non-deprecated method targeting N (API 24), when it was introduced.Android Studio weirdly suggests to remove this new redundant expression, but not sure why:
Related Issues
Fixes flutter/flutter#37616
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?