Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[e2e] Fix e2e pixel ratio #2842

Merged
dnfield merged 3 commits into from
Jun 23, 2020
Merged

[e2e] Fix e2e pixel ratio #2842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
629660a
Fix e2e device pixel ratio
CareF Jun 23, 2020
95cd37a
Update changelog and version
CareF Jun 23, 2020
cb1634e
Formatting
CareF Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/e2e/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.0+1

* Fixed the device pixel ratio problem.

## 0.5.0

* **Breaking change** by default, tests will use the device window size.
Expand Down
4 changes: 2 additions & 2 deletions packages/e2e/lib/e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ class E2EWidgetsFlutterBinding extends LiveTestWidgetsFlutterBinding {
bool get registerTestTextInput => false;

@override
ViewConfiguration createViewConfiguration() =>
TestViewConfiguration(size: window.physicalSize);
ViewConfiguration createViewConfiguration() => TestViewConfiguration(
size: window.physicalSize / window.devicePixelRatio);

final Completer<bool> _allTestsPassed = Completer<bool>();

Expand Down
2 changes: 1 addition & 1 deletion packages/e2e/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: e2e
description: Runs tests that use the flutter_test API as integration tests.
version: 0.5.0
version: 0.5.0+1
homepage: https://github.com/flutter/plugins/tree/master/packages/e2e

environment:
Expand Down