This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[shared_preferences_linux] Add iOS stub #2865
Merged
stuartmorgan-g
merged 2 commits into
flutter:master
from
stuartmorgan-g:shared_prefs_linux_ios_stub
Jul 8, 2020
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
packages/shared_preferences/shared_preferences_linux/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| ## 0.0.2 | ||
| * Add iOS stub. | ||
|
|
||
| ## 0.0.1 | ||
| * Initial release to support shared_preferences on Linux. | ||
22 changes: 22 additions & 0 deletions
22
packages/shared_preferences/shared_preferences_linux/ios/shared_preferences_linux.podspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # | ||
| # To learn more about a Podspec see http://guides.cocoapods.org/syntax/podspec.html. | ||
| # Run `pod lib lint shared_preferences_launcher_linux.podspec' to validate before publishing. | ||
| # | ||
| Pod::Spec.new do |s| | ||
| s.name = 'shared_preferences_linux' | ||
| s.version = '0.0.1' | ||
| s.summary = 'shared_preferences_linux iOS stub' | ||
| s.description = <<-DESC | ||
| No-op implementation of the Linux shared_preferences plugin to avoid build issues on iOS | ||
| DESC | ||
| s.homepage = 'https://github.com/flutter/plugins' | ||
| s.license = { :type => 'BSD', :file => '../LICENSE' } | ||
| s.author = { 'Flutter Dev Team' => 'flutter-dev@googlegroups.com' } | ||
| s.source = { :http => 'https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences_linux' } | ||
| s.dependency 'Flutter' | ||
| s.platform = :ios, '8.0' | ||
|
|
||
| # Flutter.framework does not contain a i386 slice. Only x86_64 simulators are supported. | ||
| s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' } | ||
| s.swift_version = '5.0' | ||
| end |
2 changes: 1 addition & 1 deletion
2
packages/shared_preferences/shared_preferences_linux/pubspec.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits: I think this should be just a patch? 0.0.1+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to be able to specify the dependency in the endorsement so that it requires this version; I assumed build numbers weren't valid for that purpose so did a minor version instead.