This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[integration_test] Fix channel name for iOS, docs #2972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahaog
commented
Aug 27, 2020
|
|
||
| ``` | ||
| ```sh | ||
| cd example |
Member
Author
There was a problem hiding this comment.
I'm not really sure what this means... Is it referring to the example app in packages/integration_test/example? If so we should update the file names accordingly, and perhaps we should move the following docs there and direct users there from here.
Member
Author
There was a problem hiding this comment.
Filed flutter/flutter#64690, will follow up separately
dnfield
reviewed
Aug 27, 2020
| @@ -1,6 +1,6 @@ | |||
| #import "IntegrationTestPlugin.h" | |||
|
|
|||
| static NSString *const kIntegrationTestPluginChannel = @"plugins.flutter.io/integratoin_test"; | |||
Contributor
There was a problem hiding this comment.
I could have sworn @bparrishMines fixed this previously.
Contributor
There was a problem hiding this comment.
Sorry, I was supposed to. I got distracted while waiting for our CI to go green.
KevinTheGray
added a commit
to KevinTheGray/plugins
that referenced
this pull request
Aug 31, 2020
* master: [url_launcher, url_launcher_web]Added webOnlyWindowName parameter to launch() (flutter#2979) [battery_platform_interface] Introduce package. (flutter#2975) [url_launcher_platform_interface] Add webOnlyWindowName parameter to launch() (flutter#2974) [share] Add sharing file support (android & ios) (flutter#970) [integration_test] add support to get timeline (flutter#2947) [battery] Moved battery to its own subdir (flutter#2969) [integration_test] Fix channel name for iOS, docs (flutter#2972) [integration_test] Show stack trace of widget test errors on the platform side (flutter#2967) [video_player] Fix `setWithOthers` test (flutter#2970) [video_player_platform_interface] fix `setMixIWithOthers` test channel (flutter#2968) Add README instructions for enablePendingPurchases (flutter#2921) Rebase previous commits (flutter#2966) Avoid walleye 26 Updating documentation to use isEmpty check. (flutter#2955) [integration_test] Minor cleanup (flutter#2956) [path_provider, video_player] Tweak pubspecs to pass bulk analysis. (flutter#2959) [android_intent] fix platform package dep (flutter#2948) [shared_preferences_linux] update `file` package dep version to be compatible with framework (flutter#2950)
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix channel name for iOS, docs
I haven't published
0.8.1yet, will do so after this PR to get the fix for the channel name in.