This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[flutter_plugin_android_lifecycle] add no-op v2 plugin #2977
Merged
ened
merged 11 commits into
flutter:master
from
ened:flutter_plugin_android_lifecycle-v2-plugin
Sep 4, 2020
Merged
[flutter_plugin_android_lifecycle] add no-op v2 plugin #2977
ened
merged 11 commits into
flutter:master
from
ened:flutter_plugin_android_lifecycle-v2-plugin
Sep 4, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6087741.
Member
|
LGTM. FYI @amirh |
Contributor
Author
|
@amirh could you publish to pub? |
amirh
reviewed
Sep 11, 2020
Contributor
amirh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
published, thanks! |
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
* Implement FlutterPlugin interface on the no-op plugin
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* Implement FlutterPlugin interface on the no-op plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The android lifecycle plugin currently has to ship because the build system expects a plugin.
While it does, it should implement the V2 embedding interface, so that consumers in their GeneratedPluginRegistrant won't have a instance of the ShimRegistry.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?