Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ened
Copy link
Contributor

@ened ened commented Aug 28, 2020

Description

The android lifecycle plugin currently has to ship because the build system expects a plugin.
While it does, it should implement the V2 embedding interface, so that consumers in their GeneratedPluginRegistrant won't have a instance of the ShimRegistry.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ened ened requested review from amirh and xster and removed request for xster August 28, 2020 11:29
@ened ened requested a review from xster August 28, 2020 11:30
@xster
Copy link
Member

xster commented Sep 4, 2020

LGTM. FYI @amirh

@ened ened changed the title Flutter plugin android lifecycle v2 plugin [flutter_plugin_android_lifecycle] add no-op v2 plugin Sep 4, 2020
@ened ened merged commit 5d869c4 into flutter:master Sep 4, 2020
@ened
Copy link
Contributor Author

ened commented Sep 10, 2020

@amirh could you publish to pub?

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh
Copy link
Contributor

amirh commented Sep 11, 2020

published, thanks!

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
* Implement FlutterPlugin interface on the no-op plugin
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
* Implement FlutterPlugin interface on the no-op plugin
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants