This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Standardize LICENSE body text formatting #2992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igne copies. Whitespace change only
stuartmorgan-g
requested review from
LHLL,
adazh,
amirh,
bkonyi,
bparrishMines,
cyanglaz,
dnfield,
gaaclarke,
matthew-carroll and
mklim
as code owners
amirh
reviewed
Sep 2, 2020
amirh
reviewed
Sep 2, 2020
amirh
approved these changes
Sep 2, 2020
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
LGTM modulo 2 comments inline
Hixie
approved these changes
Sep 3, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
This cleans up a number of unnecessary differences in the LICENSE files:
- Removes C++ comments ("// ") from the beginnings of all the lines in license files that had them.
- Standardizes on having a blank line after the copyright line.
- Standardizes on having the final newline in the file.
- Standardizes on the indentation of the bulleted conditions.
- Standardizes on the locations of line breaks (re-wrapping the text)
This makes the license bodies--not including the copyright line--in almost all files the same, and matches the exact formatting already used in flutter/flutter and flutter/engine.
The only remaining non-copyright-line differences should now be:
- packages/image_picker/image_picker/LICENSE has an extra license
- packages/google_sign_in/extension_google_sign_in_as_googleapis_auth/LICENSE use "Google LLC" rather than "Google Inc." in the third condition.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
This cleans up a number of unnecessary differences in the LICENSE files:
- Removes C++ comments ("// ") from the beginnings of all the lines in license files that had them.
- Standardizes on having a blank line after the copyright line.
- Standardizes on having the final newline in the file.
- Standardizes on the indentation of the bulleted conditions.
- Standardizes on the locations of line breaks (re-wrapping the text)
This makes the license bodies--not including the copyright line--in almost all files the same, and matches the exact formatting already used in flutter/flutter and flutter/engine.
The only remaining non-copyright-line differences should now be:
- packages/image_picker/image_picker/LICENSE has an extra license
- packages/google_sign_in/extension_google_sign_in_as_googleapis_auth/LICENSE use "Google LLC" rather than "Google Inc." in the third condition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleans up a number of unnecessary differences in the LICENSE files:
This makes the license bodies--not including the copyright line--in almost all files the same, and matches the exact formatting already used in flutter/flutter and flutter/engine.
The only remaining non-copyright-line differences that I'm aware of at this point are:
Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?