Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] update documentation to indicate gesture handling issues on iOS 13.4 and 13.5 #3259

Merged
merged 1 commit into from
Nov 10, 2020
Merged

[webview_flutter] update documentation to indicate gesture handling issues on iOS 13.4 and 13.5 #3259

merged 1 commit into from
Nov 10, 2020

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 9, 2020 •
edited
Loading

Description

See issue: flutter/flutter#53490

Related Issues

Fix: flutter/flutter#67541

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz cyanglaz requested a review from amirh as a code owner November 9, 2020 20:55
@google-cla google-cla bot added the cla: yes label Nov 9, 2020
bparrishMines
bparrishMines approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit d256f56 into flutter:master Nov 10, 2020
@cyanglaz cyanglaz deleted the webview_documentation branch November 10, 2020 01:19
fesp pushed a commit to fesp/plugins that referenced this pull request Nov 11, 2020
[webview_flutter] update documentation to indicate gesture handling i…
a5a3943 
…ssues on iOS 13.4 and 13.5 (flutter#3259)
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
[webview_flutter] update documentation to indicate gesture handling i…
81c1dae 
…ssues on iOS 13.4 and 13.5 (flutter#3259)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

@amirh amirh Awaiting requested review from amirh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation on webview_flutter that the gesture handling is not well supported on iOS 13.4 and iOS 13.5
2 participants
@cyanglaz @bparrishMines