Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ShahinTaj01
Copy link

Adds implementation for updateTileOverlay in google_maps_flutter_web to prevent UnimplementedException.
This PR Fixes Issue: flutter/flutter#76361

@google-cla
Copy link

google-cla bot commented Feb 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ShahinTaj01
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 27, 2021
@ShahinTaj01 ShahinTaj01 marked this pull request as draft February 27, 2021 14:32
@ShahinTaj01 ShahinTaj01 marked this pull request as ready for review February 28, 2021 09:51
@ShahinTaj01
Copy link
Author

@ditman Could you help review this ?

@ditman
Copy link
Member

ditman commented Mar 1, 2021

This is looking great! Thanks for the contribution!

As discussed in the original issue, please also implement the clearTileCache method as an empty method? That way all the "Tiles"-related functionality won't crash in web.

As a quick review; there's a checklist when you create a new PR with a bunch of things that need to be done before the PR can be merged. I'm going to list the missing stuff so we can merge this:

  1. Add a test here so we can verify that calling the methods you added don't throw exceptions anymore (a completion test of the returned value is more than enough).
  2. Update pubspec.yaml (with a bump to the patch version number, so everybody picks up this change automatically)
  3. Update CHANGELOG.md with a brief description of the changes.

Thanks!

@ditman
Copy link
Member

ditman commented Mar 3, 2021

I'm merging this into: #3673

Thanks for the contribution @ShahinTaj01!

@ditman ditman closed this Mar 3, 2021
@ditman
Copy link
Member

ditman commented Mar 3, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants