Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Migrate maven repo from jcenter to mavenCentral #3908

Merged
merged 2 commits into from
May 20, 2021
Merged

[camera] Migrate maven repo from jcenter to mavenCentral #3908

merged 2 commits into from
May 20, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 18, 2021

The jcenter maven repository is being sunset and is currently readonly. Migrate to mavenCentral.

Remove exoplayer workaround introduced in #977. See also google/ExoPlayer#5246.
Remove trailing whitespace from CHANGELOG and pubspec.

camera part of flutter/flutter#82847

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman requested a review from bparrishMines as a code owner May 18, 2021 21:21
@jmagman jmagman self-assigned this May 18, 2021
@google-cla google-cla bot added the cla: yes label May 18, 2021
mvanbeusekom
mvanbeusekom suggested changes May 19, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version number should be updated as a patch update. Since the Camera plugin is still in preview the version digits move one position to the left according to the Package versioning documentation.

packages/camera/camera/CHANGELOG.md Outdated Show resolved Hide resolved
packages/camera/camera/pubspec.yaml Outdated Show resolved Hide resolved
@jmagman @mvanbeusekom
Patch update
3536600 
Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
@jmagman
Copy link
Member Author

jmagman commented May 19, 2021

I think the version number should be updated as a patch update. Since the Camera plugin is still in preview the version digits move one position to the left according to the Package versioning documentation.

Thanks for the catch, done!

mvanbeusekom
mvanbeusekom approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 19, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 19, 2021
@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 19, 2021
@fluttergithubbot fluttergithubbot merged commit f55c868 into flutter:master May 20, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2021
@engine-flutter-autoroll
f55c868 [camera] Migrate maven repo from jcenter to mavenCentral (flu…
3c56118 
…tter/plugins#3908)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2021
@engine-flutter-autoroll
f55c868 [camera] Migrate maven repo from jcenter to mavenCentral (flu…
f7bc11a 
…tter/plugins#3908)
@jmagman jmagman deleted the cam-jcenter branch May 20, 2021 18:08
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@jmagman @fotiDim
[camera] Migrate maven repo from jcenter to mavenCentral (flutter#3908)
7945a2b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees

@jmagman jmagman

Labels
cla: yes p: camera platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmagman @fluttergithubbot @mvanbeusekom @stuartmorgan