This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_plugin_tools] Make firebase-test-lab fail when no tests run #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a package supports Android, it will now report failure instead of skip if no tests run. This matches the new behavior of `drive-examples`, and is intended to prevent recurrance of situations where we are silently failing to run tests because of, e.g., tests being in the wrong directory.
stuartmorgan
commented
Jul 20, 2021
| @@ -110,31 +109,34 @@ class FirebaseTestLabCommand extends PackageLoopingCommand { | |||
| print(''); | |||
| if (exitCode == 0) { | |||
| print('Firebase project configured.'); | |||
| return; | |||
There was a problem hiding this comment.
This is the actual fix for the bug, but the Completer was needlessly complex so I cleaned it up as well.
|
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
blasten
reviewed
Jul 21, 2021
| contains('No androidTest directory found.'), | ||
| contains('The following packages had errors:'), | ||
| contains('plugin:\n' | ||
| ' No tests ran (use --exclude if this is intentional).'), |
There was a problem hiding this comment.
nit: does it make sense to say where --exclude should be used? e.g. in .cirrus.yml?
There was a problem hiding this comment.
It can be useful locally as well; in any scenario where someone sees this message, they are trying to run a failing package, so might want to exclude it.
10 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…lutter#4172) If a package supports Android, it will now report failure instead of skip if no tests run. This matches the new behavior of drive-examples, and is intended to prevent recurrance of situations where we are silently failing to run tests because of, e.g., tests being in the wrong directory. Also fixes a long-standing but unnoticed problem where if a run tried to run more than one package's tests, it would hang forever (although on the bots it doesn't seem to time out, just end logs abruptly) due to a logic error in the call to configure gcloud. Fixes flutter/flutter#86732
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
…lutter#4172) If a package supports Android, it will now report failure instead of skip if no tests run. This matches the new behavior of drive-examples, and is intended to prevent recurrance of situations where we are silently failing to run tests because of, e.g., tests being in the wrong directory. Also fixes a long-standing but unnoticed problem where if a run tried to run more than one package's tests, it would hang forever (although on the bots it doesn't seem to time out, just end logs abruptly) due to a logic error in the call to configure gcloud. Fixes flutter/flutter#86732
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package supports Android, it will now report failure instead of
skip if no tests run. This matches the new behavior of
drive-examples,and is intended to prevent recurrance of situations where we are
silently failing to run tests because of, e.g., tests being in the wrong
directory.
Also fixes a long-standing but unnoticed problem where if a
run tried to run more than one package's tests, it would hang
forever (although on the bots it doesn't seem to time out, just
end logs abruptly) due to a logic error in the call to configure
gcloud.
Fixes flutter/flutter#86732
Pre-launch Checklist
dart format.)[shared_preferences]///).