Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Reworks the logic in updateMetaData:toImage: to correctly handle the
possibility of null return values from intermediate steps. Also renames
it to have a more idiomatic ObjC name.

Speculative fix for flutter/flutter#80429
Since the case this would likely fix is bad image data, this may simply
move problems to another part of the plugin, but this is definitely a
correctness improvement here, and if it does move the issue elsewhere we
can tackle that once we have more information.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

Reworks the logic in updateMetaData:toImage: to correctly handle the
possibility of null return values from intermediate steps. Also renames
it to have a more idiomatic ObjC name.

Speculative fix for flutter/flutter#80429
Since the case this would likely fix is bad image data, this may simply
move problems to another part of the plugin, but this is definitely a
correctness improvement here, and if it does move the issue elsewhere we
can tackle that once we have more information.
@stuartmorgan-g
Copy link
Contributor Author

I wanted to fix the incorrect capitalization of MetaData, but that's everywhere in this plugin, so that would have been a much bigger change (or inconsistent in this one method, which would be worse than it being wrong everywhere).

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 3, 2021
@fluttergithubbot fluttergithubbot merged commit 643c928 into flutter:master Aug 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
jolmiracle pushed a commit to miracle-as/webview_flutter that referenced this pull request Sep 24, 2021
# Conflicts:
#	packages/image_picker/image_picker/CHANGELOG.md
#	packages/image_picker/image_picker/pubspec.yaml
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes p: image_picker platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants