-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[video_player] add support for content-uri based videos (android only) #4261
Conversation
| @@ -1,5 +1,6 @@ | |||
| ## NEXT | |||
| ## 2.1.15 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: a new feature should bump the minor version rather than the patch.
|
Thanks for the submission! @blasten This looks pretty straightforward; can you take a look? |
|
|
||
| # FOR TESTING ONLY. DO NOT MERGE. | ||
| dependency_overrides: | ||
| video_player_platform_interface: | ||
| path: | ||
| ../../video_player_platform_interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be removed once the PR is split (https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins). It can't accidentally be left because this fails publishable.
|
@byunme Are you planning on splitting this into the component PRs now so that we can move forward with landing this? |
|
@stuartmorgan Sorry for the delay, I've split off the interface part here: #4307 |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
This PR adds playback from contentUri support for the video_player plugin (Android only).
The current Android implementation uses ExoPlayer, which already supports playback from uri, so this change is just to surface contentUri as a valid video datasource on the dart side.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#88130
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.