This repository was archived by the owner on Feb 22, 2023. It is now read-only.
  
  
  - 
                Notifications
    
You must be signed in to change notification settings  - Fork 9.7k
 
[camera] Ensure setExposureOffset returns new value on Android #4301
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           
  | 
    
              
                    BeMacized
  
              
              approved these changes
              
                  
                    Sep 2, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for the tree to turn green
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 2, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 2, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 2, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 2, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 2, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 2, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 3, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 3, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 3, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  fotiDim 
      pushed a commit
        to fotiDim/plugins
      that referenced
      this pull request
    
      Sep 13, 2021 
    
    
  
    
  amantoux 
      pushed a commit
        to amantoux/plugins
      that referenced
      this pull request
    
      Sep 27, 2021 
    
    
  
    
  KyleFin 
      pushed a commit
        to KyleFin/plugins
      that referenced
      this pull request
    
      Dec 21, 2021 
    
    
  
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
      
    bugfix
  
    cla: yes
  
    p: camera
  
    platform-android
  
    waiting for tree to go green
  (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Since version 0.9.0 the Android
setExposureOffsetmethod doesn't return the newly configured offset after updating the exposure offset. This will cause aUnhandled Exception: Null check operator used on a null valueerror in the camera_platform_interface as it does expect a result.This PR fixes the problem by correctly returning the newly configured exposure offset on Android.
Resolves flutter/flutter#89281
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.