This repository was archived by the owner on Feb 22, 2023. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 9.7k
[ci] Fix and standardize target/task names #4323
          
     Merged
      
      
            stuartmorgan-g
  merged 1 commit into
  flutter:master
from
stuartmorgan-g:task-name-fix-and-standardize
  
      
      
   
  Sep 8, 2021 
      
    
                
     Merged
            
            [ci] Fix and standardize target/task names #4323
                    stuartmorgan-g
  merged 1 commit into
  flutter:master
from
stuartmorgan-g:task-name-fix-and-standardize
  
      
      
   
  Sep 8, 2021 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Fixes the target names in LUCI to not use '+', since it's not supported. To better align the names between the two different infrastructures, also updates the task naming in cirrus.yml to not use +. It also standardizes the naming form across both systems as: `<Host platform> <target platform>-<test_name> <extra info>` where: - `<Host platform>` is always there on LUCI, where required, but only added where it's potentially ambiguous on Cirrus - `<target platform>' is omitted when the test is not target-platform specific - `<test_name>' uses underscores, which is consistent with flutter/flutter (and with Cirrus step naming). - `<extra info>` is only explicitly set (to the channel) on LUCI; Cirrus automatically adds channel info there due to the way `matrix` works.
              
                    CaseyHillers
  
              
              approved these changes
              
                  
                    Sep 8, 2021 
                  
              
              
            
            
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  NickalasB 
      added a commit
        to NickalasB/plugins
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
      
  
    
      
    
  
* master: [ci] Fix and standardize target/task names (flutter#4323) Bring up new Windows test targets (flutter#4311)
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 8, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  engine-flutter-autoroll 
      added a commit
        to engine-flutter-autoroll/flutter
      that referenced
      this pull request
    
      Sep 9, 2021 
    
    
  
    
  fotiDim 
      pushed a commit
        to fotiDim/plugins
      that referenced
      this pull request
    
      Sep 13, 2021 
    
    
      
  
    
      
    
  
Fixes the target names in LUCI to not use '+', since it's not supported. To better align the names between the two different infrastructures, also updates the task naming in cirrus.yml to not use +. It also standardizes the naming form across both systems as: `<Host platform> <target platform>-<test_name> <extra info>` where: - `<Host platform>` is always there on LUCI, where required, but only added where it's potentially ambiguous on Cirrus. - `<target platform>' is omitted when the test is not target-platform specific. - `<test_name>' uses underscores, which is consistent with flutter/flutter (and with Cirrus step naming). - `<extra info>` is only explicitly set (to the channel) on LUCI; Cirrus automatically adds channel info there due to the way `matrix` works.
    
  amantoux 
      pushed a commit
        to amantoux/plugins
      that referenced
      this pull request
    
      Sep 27, 2021 
    
    
      
  
    
      
    
  
Fixes the target names in LUCI to not use '+', since it's not supported. To better align the names between the two different infrastructures, also updates the task naming in cirrus.yml to not use +. It also standardizes the naming form across both systems as: `<Host platform> <target platform>-<test_name> <extra info>` where: - `<Host platform>` is always there on LUCI, where required, but only added where it's potentially ambiguous on Cirrus. - `<target platform>' is omitted when the test is not target-platform specific. - `<test_name>' uses underscores, which is consistent with flutter/flutter (and with Cirrus step naming). - `<extra info>` is only explicitly set (to the channel) on LUCI; Cirrus automatically adds channel info there due to the way `matrix` works.
    
  KyleFin 
      pushed a commit
        to KyleFin/plugins
      that referenced
      this pull request
    
      Dec 21, 2021 
    
    
      
  
    
      
    
  
Fixes the target names in LUCI to not use '+', since it's not supported. To better align the names between the two different infrastructures, also updates the task naming in cirrus.yml to not use +. It also standardizes the naming form across both systems as: `<Host platform> <target platform>-<test_name> <extra info>` where: - `<Host platform>` is always there on LUCI, where required, but only added where it's potentially ambiguous on Cirrus. - `<target platform>' is omitted when the test is not target-platform specific. - `<test_name>' uses underscores, which is consistent with flutter/flutter (and with Cirrus step naming). - `<extra info>` is only explicitly set (to the channel) on LUCI; Cirrus automatically adds channel info there due to the way `matrix` works.
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes the target names in LUCI to not use '+', since it's not supported.
To better align the names between the two different infrastructures,
also updates the task naming in cirrus.yml to not use +. It also
standardizes the naming form across both systems as:
<Host platform> <target platform>-<test_name> <extra info>where:
<Host platform>is always there on LUCI, where required, but onlyadded where it's potentially ambiguous on Cirrus
specific
flutter/flutter (and with Cirrus step naming).
<extra info>is only explicitly set (to the channel) on LUCI; Cirrusautomatically adds channel info there due to the way
matrixworks.Pre-launch Checklist
dart format.)[shared_preferences]///).