Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fix in_app_purchase_android/README.md #4363

Merged
merged 8 commits into from
Sep 30, 2021
Merged

[in_app_purchase] Fix in_app_purchase_android/README.md #4363

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
27af99e
Fix broken README link.
Uda-Titor Sep 18, 2021
2a81932
fix: in README.md in_app_purchase_android
Uda-Titor Sep 21, 2021
24409e6
fix: pubspec.yml and CHANGELOG.md
Uda-Titor Sep 21, 2021
aa2a2f0
Merge remote-tracking branch 'upstream/master' into fix/in_app_purcha…
Uda-Titor Sep 21, 2021
e87c38d
update: in_app_purchase_android/pubspec.yaml
Uda-Titor Sep 21, 2021
62ad56b
fix: in_app_purchase_android/README.md
Uda-Titor Sep 21, 2021
37e7f28
retrigger ci
Uda-Titor Sep 27, 2021
f6325f5
Merge remote-tracking branch 'upstream/master' into fix/in_app_purcha…
Uda-Titor Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.4+8

* Fix broken link in packages/in_app_purchase/in_app_purchase_android/README.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the CHANGELOG is already part of the packages/in_app_purchase/in_app_purchase_android folder you can leave this out of the comment as it is more difficult to read and might confuse users. The following should suffice:

Suggested change
* Fix broken link in packages/in_app_purchase/in_app_purchase_android/README.
* Fix a broken link in the README.


## 0.1.4+7

* Ensure that the `SkuDetailsWrapper.introductoryPriceMicros` is populated correctly.
Expand Down
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_android/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ If you would like to contribute to the plugin, check out our
[contribution guide](https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md).


[1]: ../in_app_purchase/in_app_purchase
[1]: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryoheiudagawa1995, I think it is better to point to the repository of in_app_purchase package it self (which would be https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/in_app_purchase, since that is wat the text is also referring to (to the in_app_purchase package). Thinking about it, it would make even more sense to point to the package on pub.dev as that is where most users would retrieve it from.

Should have thought about that the first time (sorry) but maybe you can do another update and change it to:

Suggested change
[1]: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase
[1]: https://pub.dev/packages/in_app_purchase

[2]: https://flutter.dev/docs/development/packages-and-plugins/developing-packages#endorsed-federated-plugin
[3]: https://pub.dev/packages/in_app_purchase_android/install
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: in_app_purchase_android
description: An implementation for the Android platform of the Flutter `in_app_purchase` plugin. This uses the Android BillingClient APIs.
repository: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/in_app_purchase_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22
version: 0.1.4+7
version: 0.1.4+8

environment:
sdk: ">=2.12.0 <3.0.0"
Expand Down