Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix order-dependant platform interface tests #4406

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Fix order-dependant platform interface tests #4406

merged 1 commit into from
Oct 1, 2021

Conversation

stuartmorgan
Copy link
Contributor

Fixes all instance of an anti-pattern that was cloned among many of our
platform interfaces, where one test asserts that the static instance is
of a specific class, but other tests change that static instance, such
that the initial test fails if not run first.

Fixes flutter/flutter#52690
Fixes flutter/flutter#52689

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
Fix order-dependant platform interface tests
d9fed59 
Fixes all instance of an anti-pattern that was cloned among many of our
platform interfaces, where one test asserts that the static instance is
of a specific class, but other tests change that static instance, such
that the initial test fails if not run first.

Fixes flutter/flutter#52690
Fixes flutter/flutter#52689
@stuartmorgan stuartmorgan requested a review from gaaclarke October 1, 2021 17:48
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
cyanglaz
cyanglaz approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Oct 1, 2021
@fluttergithubbot fluttergithubbot merged commit a12791c into flutter:master Oct 1, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 1, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
54a3173 
…#4406)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
b733a61 
…#4406)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
20119f9 
…#4406)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
d36993a 
…#4406)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
ec90c47 
…#4406)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
f694baf 
…#4406)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
deee6f6 
…#4406)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Oct 5, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
3fd5a64 
* master:
  [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404)
  [ci] Remove obsolete Dockerfile (flutter#4405)
  Fix order-dependant platform interface tests (flutter#4406)
  [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 5, 2021
@engine-flutter-autoroll
a12791c Fix order-dependant platform interface tests (flutter/plugins…
665501c 
…#4406)
mgonzalezc pushed a commit to mgonzalezc/plugins that referenced this pull request Oct 12, 2021
Merge branch 'master' into quick_actions_mindapps
419b195 
* master: (1126 commits)
  [webview_flutter] Adjust test URLs again (flutter#4407)
  [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179)
  [camera] Add filter for unsupported cameras on Android (flutter#4418)
  [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401)
  [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404)
  [ci] Remove obsolete Dockerfile (flutter#4405)
  Fix order-dependant platform interface tests (flutter#4406)
  [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374)
  [google_maps_flutter] Add Marker drag events (flutter#2838)
  [flutter_plugin_tools] Validate pubspec description (flutter#4396)
  Add file_selector to the repo list (flutter#4395)
  [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)
  [google_maps_flutter_web] Add Marker drag events (flutter#4385)
  [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394)
  Handle `PurchaseStatus.restored` correctly in example. (flutter#4393)
  Handle restored purchases in iOS example app (flutter#4392)
  [file_selector] Remove custom analysis options (flutter#4382)
  [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373)
  Fixed _CastError when running example App (flutter#4390)
  [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370)
  ...

# Conflicts:
#	packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
camsim99 pushed a commit to camsim99/plugins that referenced this pull request Oct 18, 2021
@stuartmorgan @camsim99
Fix order-dependant platform interface tests (flutter#4406)
232994f
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan @amantoux
Fix order-dependant platform interface tests (flutter#4406)
0da1851
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan @KyleFin
Fix order-dependant platform interface tests (flutter#4406)
a893550
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

@ditman ditman Awaiting requested review from ditman

Assignees
No one assigned
Labels
cla: yes p: file_selector p: google_maps_flutter p: google_sign_in p: quick_actions p: url_launcher p: video_player waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[url_launcher] has order-dependent tests [google_sign_in] has order-dependent test
3 participants
@stuartmorgan @cyanglaz @fluttergithubbot