This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera]writing file on background queue #4721
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| @import camera; | ||
| @import camera.Test; | ||
| @import AVFoundation; | ||
| @import XCTest; | ||
| #import <OCMock/OCMock.h> | ||
|
|
||
| @interface FLTSavePhotoDelegateTests : XCTestCase | ||
|
|
||
| @end | ||
|
|
||
| @implementation FLTSavePhotoDelegateTests | ||
|
|
||
| - (void)testHandlePhotoCaptureResult_mustSendErrorIfFailedToCapture { | ||
| NSError *error = [NSError errorWithDomain:@"test" code:0 userInfo:nil]; | ||
| dispatch_queue_t ioQueue = dispatch_queue_create("test", NULL); | ||
| id mockResult = OCMClassMock([FLTThreadSafeFlutterResult class]); | ||
| FLTSavePhotoDelegate *delegate = [[FLTSavePhotoDelegate alloc] initWithPath:@"test" | ||
| result:mockResult | ||
| ioQueue:ioQueue]; | ||
|
|
||
| [delegate handlePhotoCaptureResultWithError:error | ||
| photoDataProvider:^NSData * { | ||
| return nil; | ||
| }]; | ||
| OCMVerify([mockResult sendError:error]); | ||
| } | ||
|
|
||
| - (void)testHandlePhotoCaptureResult_mustSendErrorIfFailedToWrite { | ||
| XCTestExpectation *resultExpectation = | ||
| [self expectationWithDescription:@"Must send IOError to the result if failed to write file."]; | ||
| dispatch_queue_t ioQueue = dispatch_queue_create("test", NULL); | ||
| id mockResult = OCMClassMock([FLTThreadSafeFlutterResult class]); | ||
|
|
||
| NSError *ioError = [NSError errorWithDomain:@"IOError" | ||
| code:0 | ||
| userInfo:@{NSLocalizedDescriptionKey : @"Localized IO Error"}]; | ||
|
|
||
| OCMStub([mockResult sendErrorWithCode:@"IOError" | ||
| message:@"Unable to write file" | ||
| details:ioError.localizedDescription]) | ||
| .andDo(^(NSInvocation *invocation) { | ||
| [resultExpectation fulfill]; | ||
| }); | ||
| FLTSavePhotoDelegate *delegate = [[FLTSavePhotoDelegate alloc] initWithPath:@"test" | ||
| result:mockResult | ||
| ioQueue:ioQueue]; | ||
|
|
||
| // We can't use OCMClassMock for NSData because some XCTest APIs uses NSData (e.g. | ||
| // `XCTRunnerIDESession::logDebugMessage:`) on a private queue. | ||
| id mockData = OCMPartialMock([NSData data]); | ||
| OCMStub([mockData writeToFile:OCMOCK_ANY | ||
| options:NSDataWritingAtomic | ||
| error:[OCMArg setTo:ioError]]) | ||
| .andReturn(NO); | ||
| [delegate handlePhotoCaptureResultWithError:nil | ||
| photoDataProvider:^NSData * { | ||
| return mockData; | ||
| }]; | ||
| [self waitForExpectationsWithTimeout:1 handler:nil]; | ||
| } | ||
|
|
||
| - (void)testHandlePhotoCaptureResult_mustSendSuccessIfSuccessToWrite { | ||
| XCTestExpectation *resultExpectation = [self | ||
| expectationWithDescription:@"Must send file path to the result if success to write file."]; | ||
|
|
||
| dispatch_queue_t ioQueue = dispatch_queue_create("test", NULL); | ||
| id mockResult = OCMClassMock([FLTThreadSafeFlutterResult class]); | ||
| FLTSavePhotoDelegate *delegate = [[FLTSavePhotoDelegate alloc] initWithPath:@"test" | ||
| result:mockResult | ||
| ioQueue:ioQueue]; | ||
| OCMStub([mockResult sendSuccessWithData:delegate.path]).andDo(^(NSInvocation *invocation) { | ||
| [resultExpectation fulfill]; | ||
| }); | ||
|
|
||
| // We can't use OCMClassMock for NSData because some XCTest APIs uses NSData (e.g. | ||
| // `XCTRunnerIDESession::logDebugMessage:`) on a private queue. | ||
| id mockData = OCMPartialMock([NSData data]); | ||
| OCMStub([mockData writeToFile:OCMOCK_ANY options:NSDataWritingAtomic error:[OCMArg setTo:nil]]) | ||
| .andReturn(YES); | ||
|
|
||
| [delegate handlePhotoCaptureResultWithError:nil | ||
| photoDataProvider:^NSData * { | ||
| return mockData; | ||
| }]; | ||
| [self waitForExpectationsWithTimeout:1 handler:nil]; | ||
| } | ||
|
|
||
| - (void)testHandlePhotoCaptureResult_bothProvideDataAndSaveFileMustRunOnIOQueue { | ||
| XCTestExpectation *dataProviderQueueExpectation = | ||
| [self expectationWithDescription:@"Data provider must run on io queue."]; | ||
| XCTestExpectation *writeFileQueueExpectation = | ||
| [self expectationWithDescription:@"File writing must run on io queue"]; | ||
| XCTestExpectation *resultExpectation = [self | ||
| expectationWithDescription:@"Must send file path to the result if success to write file."]; | ||
|
|
||
| dispatch_queue_t ioQueue = dispatch_queue_create("test", NULL); | ||
| const char *ioQueueSpecific = "io_queue_specific"; | ||
| dispatch_queue_set_specific(ioQueue, ioQueueSpecific, (void *)ioQueueSpecific, NULL); | ||
| id mockResult = OCMClassMock([FLTThreadSafeFlutterResult class]); | ||
| OCMStub([mockResult sendSuccessWithData:OCMOCK_ANY]).andDo(^(NSInvocation *invocation) { | ||
| [resultExpectation fulfill]; | ||
| }); | ||
|
|
||
| // We can't use OCMClassMock for NSData because some XCTest APIs uses NSData (e.g. | ||
| // `XCTRunnerIDESession::logDebugMessage:`) on a private queue. | ||
| id mockData = OCMPartialMock([NSData data]); | ||
| OCMStub([mockData writeToFile:OCMOCK_ANY options:NSDataWritingAtomic error:[OCMArg setTo:nil]]) | ||
| .andDo(^(NSInvocation *invocation) { | ||
| if (dispatch_get_specific(ioQueueSpecific)) { | ||
| [writeFileQueueExpectation fulfill]; | ||
| } | ||
| }) | ||
| .andReturn(YES); | ||
|
|
||
| FLTSavePhotoDelegate *delegate = [[FLTSavePhotoDelegate alloc] initWithPath:@"test" | ||
| result:mockResult | ||
| ioQueue:ioQueue]; | ||
| [delegate handlePhotoCaptureResultWithError:nil | ||
| photoDataProvider:^NSData * { | ||
| if (dispatch_get_specific(ioQueueSpecific)) { | ||
| [dataProviderQueueExpectation fulfill]; | ||
| } | ||
| return mockData; | ||
| }]; | ||
|
|
||
| [self waitForExpectationsWithTimeout:1 handler:nil]; | ||
| } | ||
|
|
||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
|
Member
There was a problem hiding this comment. This is now exposed in the plugin API, I don't think we want that. I think keep most of this in the implementation and only expose
Contributor
Author
There was a problem hiding this comment. Oh I didn't add it to the umbrella header so it's not exposed outside of this package.
Contributor
Author
There was a problem hiding this comment. Also removed thread safe wrappers from the umbrella header
Member
There was a problem hiding this comment. Oh right right I forgot this uses a real umbrella header and not one generated by CocoaPods. I think you're still exposing it in the test module since you're
Contributor
Author
There was a problem hiding this comment. The original header and the test header are both exposed for unit test only. I think this is what we want. |
||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| @import AVFoundation; | ||
| @import Foundation; | ||
| @import Flutter; | ||
|
|
||
| #import "FLTThreadSafeFlutterResult.h" | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| /** | ||
| Delegate object that handles photo capture results. | ||
| */ | ||
| @interface FLTSavePhotoDelegate : NSObject <AVCapturePhotoCaptureDelegate> | ||
| /// The file path for the captured photo. | ||
| @property(readonly, nonatomic) NSString *path; | ||
| /// The thread safe flutter result wrapper to report the result. | ||
| @property(readonly, nonatomic) FLTThreadSafeFlutterResult *result; | ||
| /// The queue on which captured photos are wrote to disk. | ||
| @property(strong, nonatomic) dispatch_queue_t ioQueue; | ||
| /// Used to keep the delegate alive until didFinishProcessingPhotoSampleBuffer. | ||
| @property(strong, nonatomic, nullable) FLTSavePhotoDelegate *selfReference; | ||
|
|
||
| /** | ||
| * Initialize a photo capture delegate. | ||
| * @param path the path for captured photo file. | ||
| * @param result the thread safe flutter result wrapper to report the result. | ||
| * @param ioQueue the queue on which captured photos are wrote to disk. | ||
| */ | ||
| - (instancetype)initWithPath:(NSString *)path | ||
| result:(FLTThreadSafeFlutterResult *)result | ||
| ioQueue:(dispatch_queue_t)ioQueue; | ||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.