This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[Camera] Return all possible cameras on iOS #5636
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| @import camera; | ||
| @import camera.Test; | ||
| @import XCTest; | ||
| @import AVFoundation; | ||
| #import <OCMock/OCMock.h> | ||
| #import "MockFLTThreadSafeFlutterResult.h" | ||
|
|
||
| @interface AvailableCamerasTest : XCTestCase | ||
| @end | ||
|
|
||
| @implementation AvailableCamerasTest | ||
|
|
||
| - (void)testAvailableCamerasShouldReturnAllCamerasOnMultiCameraIPhone { | ||
| CameraPlugin *camera = [[CameraPlugin alloc] initWithRegistry:nil messenger:nil]; | ||
| XCTestExpectation *expectation = | ||
| [[XCTestExpectation alloc] initWithDescription:@"Result finished"]; | ||
|
|
||
| // iPhone 13 Cameras: | ||
| AVCaptureDevice *wideAngleCamera = OCMClassMock([AVCaptureDevice class]); | ||
| OCMStub([wideAngleCamera uniqueID]).andReturn(@"0"); | ||
| OCMStub([wideAngleCamera position]).andReturn(AVCaptureDevicePositionBack); | ||
|
|
||
| AVCaptureDevice *frontFacingCamera = OCMClassMock([AVCaptureDevice class]); | ||
| OCMStub([frontFacingCamera uniqueID]).andReturn(@"1"); | ||
| OCMStub([frontFacingCamera position]).andReturn(AVCaptureDevicePositionFront); | ||
|
|
||
| AVCaptureDevice *ultraWideCamera = OCMClassMock([AVCaptureDevice class]); | ||
| OCMStub([ultraWideCamera uniqueID]).andReturn(@"2"); | ||
| OCMStub([ultraWideCamera position]).andReturn(AVCaptureDevicePositionBack); | ||
|
|
||
| AVCaptureDevice *telephotoCamera = OCMClassMock([AVCaptureDevice class]); | ||
| OCMStub([telephotoCamera uniqueID]).andReturn(@"3"); | ||
| OCMStub([telephotoCamera position]).andReturn(AVCaptureDevicePositionBack); | ||
|
|
||
| NSMutableArray *requiredTypes = [NSMutableArray array]; | ||
| [requiredTypes addObjectsFromArray:@[ | ||
| AVCaptureDeviceTypeBuiltInWideAngleCamera, AVCaptureDeviceTypeBuiltInTelephotoCamera | ||
| ]]; | ||
|
There was a problem hiding this comment. This is both more readable and more performant (the latter doesn't matter in a test of course, but it's a better practice in general) as: |
||
| if (@available(iOS 13.0, *)) { | ||
| [requiredTypes addObject:AVCaptureDeviceTypeBuiltInUltraWideCamera]; | ||
| } | ||
|
|
||
| id discoverySessionMock = OCMClassMock([AVCaptureDeviceDiscoverySession class]); | ||
| OCMStub([discoverySessionMock discoverySessionWithDeviceTypes:requiredTypes | ||
| mediaType:AVMediaTypeVideo | ||
| position:AVCaptureDevicePositionUnspecified]) | ||
| .andReturn(discoverySessionMock); | ||
|
|
||
| NSMutableArray *cameras = [NSMutableArray array]; | ||
| [cameras addObjectsFromArray:@[ wideAngleCamera, frontFacingCamera, telephotoCamera ]]; | ||
| if (@available(iOS 13.0, *)) { | ||
| [cameras addObject:ultraWideCamera]; | ||
| } | ||
| OCMStub([discoverySessionMock devices]).andReturn([NSArray arrayWithArray:cameras]); | ||
|
|
||
| MockFLTThreadSafeFlutterResult *resultObject = | ||
| [[MockFLTThreadSafeFlutterResult alloc] initWithExpectation:expectation]; | ||
|
|
||
| // Set up method call | ||
| FlutterMethodCall *call = [FlutterMethodCall methodCallWithMethodName:@"availableCameras" | ||
| arguments:nil]; | ||
|
|
||
| [camera handleMethodCallAsync:call result:resultObject]; | ||
|
|
||
| // Verify the result | ||
| NSDictionary *dictionaryResult = (NSDictionary *)resultObject.receivedResult; | ||
| if (@available(iOS 13.0, *)) { | ||
| XCTAssertTrue([dictionaryResult count] == 4); | ||
| } else { | ||
| XCTAssertTrue([dictionaryResult count] == 3); | ||
| } | ||
| } | ||
| - (void)testAvailableCamerasShouldReturnOneCameraOnSingleCameraIPhone { | ||
| CameraPlugin *camera = [[CameraPlugin alloc] initWithRegistry:nil messenger:nil]; | ||
| XCTestExpectation *expectation = | ||
| [[XCTestExpectation alloc] initWithDescription:@"Result finished"]; | ||
|
|
||
| // iPhone 8 Cameras: | ||
| AVCaptureDevice *wideAngleCamera = OCMClassMock([AVCaptureDevice class]); | ||
| OCMStub([wideAngleCamera uniqueID]).andReturn(@"0"); | ||
| OCMStub([wideAngleCamera position]).andReturn(AVCaptureDevicePositionBack); | ||
|
|
||
| AVCaptureDevice *frontFacingCamera = OCMClassMock([AVCaptureDevice class]); | ||
| OCMStub([frontFacingCamera uniqueID]).andReturn(@"1"); | ||
| OCMStub([frontFacingCamera position]).andReturn(AVCaptureDevicePositionFront); | ||
|
|
||
| NSMutableArray *requiredTypes = [NSMutableArray array]; | ||
| [requiredTypes addObjectsFromArray:@[ | ||
|
|
||
| AVCaptureDeviceTypeBuiltInWideAngleCamera, AVCaptureDeviceTypeBuiltInTelephotoCamera | ||
| ]]; | ||
| if (@available(iOS 13.0, *)) { | ||
| [requiredTypes addObject:AVCaptureDeviceTypeBuiltInUltraWideCamera]; | ||
| } | ||
|
|
||
| id discoverySessionMock = OCMClassMock([AVCaptureDeviceDiscoverySession class]); | ||
| OCMStub([discoverySessionMock discoverySessionWithDeviceTypes:requiredTypes | ||
| mediaType:AVMediaTypeVideo | ||
| position:AVCaptureDevicePositionUnspecified]) | ||
| .andReturn(discoverySessionMock); | ||
|
|
||
| NSMutableArray *cameras = [NSMutableArray array]; | ||
| [cameras addObjectsFromArray:@[ wideAngleCamera, frontFacingCamera ]]; | ||
| OCMStub([discoverySessionMock devices]).andReturn([NSArray arrayWithArray:cameras]); | ||
|
|
||
| MockFLTThreadSafeFlutterResult *resultObject = | ||
| [[MockFLTThreadSafeFlutterResult alloc] initWithExpectation:expectation]; | ||
|
|
||
| // Set up method call | ||
| FlutterMethodCall *call = [FlutterMethodCall methodCallWithMethodName:@"availableCameras" | ||
| arguments:nil]; | ||
|
|
||
| [camera handleMethodCallAsync:call result:resultObject]; | ||
|
|
||
| // Verify the result | ||
| NSDictionary *dictionaryResult = (NSDictionary *)resultObject.receivedResult; | ||
| XCTAssertTrue([dictionaryResult count] == 2); | ||
| } | ||
|
|
||
| @end | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns
See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍