Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] use Object in operator == for mocking #5807

Closed
wants to merge 1 commit into from

Conversation

evan361425
Copy link

@evan361425 evan361425 commented May 23, 2022

When using mockito for GoogleSignInAccount, the static analyzer starts complaint:

'Mock.==' ('bool Function(Object)') isn't a valid concrete implementation of 'GoogleSignInAccount.==' ('bool Function(dynamic)').

Which means it should be Object in the operator =='s argument.

Fixed issues:

no changes in flutter/tests repo.

Test

As I read the suggestion: is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

I'm not sure how to add the test to prevent revert changing, any testing tips for this kind of fixes?

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@evan361425 evan361425 requested a review from stuartmorgan as a code owner May 23, 2022 01:25
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@evan361425
Copy link
Author

duplicate with #5642

@evan361425 evan361425 closed this May 23, 2022
@evan361425 evan361425 deleted the patch-1 branch May 23, 2022 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant