This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[google_sign_in] use Object in operator == for mocking #5807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using mockito for
GoogleSignInAccount
, the static analyzer starts complaint:Which means it should be
Object
in theoperator ==
's argument.Fixed issues:
no changes in flutter/tests repo.
Test
As I read the suggestion: is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
I'm not sure how to add the test to prevent revert changing, any testing tips for this kind of fixes?
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.