Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add Cloud Functions support #592

Merged
merged 7 commits into from
Jun 21, 2018
Merged

Conversation

kroikie
Copy link
Contributor

@kroikie kroikie commented May 30, 2018

Add plugin that allows use of Firebase Functions callable API.

@kroikie kroikie self-assigned this May 30, 2018
@kroikie kroikie requested a review from collinjackson May 30, 2018 18:04
@kroikie kroikie changed the title [WIP] Add Firebase Functions support [WIP] Add Cloud Functions support Jun 12, 2018
@kroikie kroikie changed the title [WIP] Add Cloud Functions support Add Cloud Functions support Jun 13, 2018
@kroikie kroikie assigned collinjackson and unassigned kroikie Jun 14, 2018
@kroikie kroikie requested a review from bparrishMines June 19, 2018 18:48
@@ -0,0 +1,8 @@
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can delete all the .gitignore files. I think we are trying to keep only one from now on from #588

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,3 @@
## 0.0.1

* Initial release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add more description on what is in the initial release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,8 @@
*.iml
Copy link
Contributor

@bparrishMines bparrishMines Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,9 @@
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,10 @@
*.iml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,45 @@
.idea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

parameters: <String, dynamic>{
'message': 'hello world!',
'count': _responseCount,
});
Copy link
Contributor

@bparrishMines bparrishMines Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comma after the '}'
It should cause dartfmt to format with 2 spaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,36 @@
.idea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how important the License header is, but you left them off for the main.dart file and both test files.

@kroikie
Copy link
Contributor Author

kroikie commented Jun 21, 2018

Added License header.

@kroikie kroikie force-pushed the add-firebase-functions branch from 853d412 to 7635ec1 Compare June 21, 2018 17:55
@kroikie kroikie merged commit d0d6b64 into flutter:master Jun 21, 2018
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Add support for Cloud Functions callable API.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants