This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_plugin_tools] If clang-format does not run, fall back to other executables in PATH
#6853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
force-pushed
the
clang-format-check
branch
from
faf341d to
d0bad67
Compare
jmagman
commented
Dec 16, 2022
| @@ -1,4 +1,8 @@ | |||
| ## 13.1 | |||
stuartmorgan-g
approved these changes
Dec 16, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Great idea, LGTM!
| print('\nTo fix run "pub global activate flutter_plugin_tools && ' | ||
| 'pub global run flutter_plugin_tools format" or copy-paste ' | ||
| print('\nTo fix run "dart pub global activate flutter_plugin_tools && ' | ||
| 'dart pub global run flutter_plugin_tools format" or copy-paste ' |
Contributor
There was a problem hiding this comment.
Thanks, I thought I'd fixed this everywhere, but apparently only in CI scripts.
| } | ||
|
|
||
| final String stdout = result.stdout as String; | ||
| if (stdout.isEmpty) { |
Contributor
There was a problem hiding this comment.
Shouldn't the trim be before this check?
| @@ -1,4 +1,8 @@ | |||
| ## 13.1 | |||
Contributor
There was a problem hiding this comment.
Oops. (Since this isn't in packages/ it doesn't get the metadata checks.)
Member
Author
There was a problem hiding this comment.
Does script/tool still need to be versioned like this?
Contributor
There was a problem hiding this comment.
I publish it periodically so that flutter/packages can use the latest updates, so it does need versioning. Once the repo merge is done it won't.
jmagman
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/plugins, pr: 6853, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 4 --shardCount 5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
Re-running the flaky test. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2022
… back to other executables in PATH (flutter/plugins#6853)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 19, 2022
* 5f62d21eb [local_auth] Fix failed biometric authentication not throwing error (flutter/plugins#6821) * ca974ab0c [webview_flutter_web] Copies web implementation of webview_flutter from v4_webview (flutter/plugins#6854) * 4d11be416 [image_picker] Don't store null paths in lost cache (flutter/plugins#6678) * fd2841fd0 [webview_flutter_android] Fix timeouts in the integration tests (flutter/plugins#6857) * abc9f9a9b [flutter_plugin_tools] If `clang-format` does not run, fall back to other executables in PATH (flutter/plugins#6853) * 7efb5e89d [video_player] Add compatibility with the current platform interface (flutter/plugins#6855) * 32dcbf3e3 [image_picker] Improve image_picker for iOS to handle more image types (flutter/plugins#6812) * 840a04954 [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview (flutter/plugins#6856)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#117314) * 5f62d21eb [local_auth] Fix failed biometric authentication not throwing error (flutter/plugins#6821) * ca974ab0c [webview_flutter_web] Copies web implementation of webview_flutter from v4_webview (flutter/plugins#6854) * 4d11be416 [image_picker] Don't store null paths in lost cache (flutter/plugins#6678) * fd2841fd0 [webview_flutter_android] Fix timeouts in the integration tests (flutter/plugins#6857) * abc9f9a9b [flutter_plugin_tools] If `clang-format` does not run, fall back to other executables in PATH (flutter/plugins#6853) * 7efb5e89d [video_player] Add compatibility with the current platform interface (flutter/plugins#6855) * 32dcbf3e3 [image_picker] Improve image_picker for iOS to handle more image types (flutter/plugins#6812) * 840a04954 [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview (flutter/plugins#6856)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…ther executables in PATH (flutter#6853) * If clang-format does not run, fall back to other executables in PATH * Review edits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
clang-formatdoes not run (i.e. failingchromium/depot_tools/clang-format, loop through all theclang-formatexecutables in the PATH until a working one is found. If none run then bail with the same error as before.Running
pub global...fails withcommand not found: pub. Updatepub globalinstructions todart pub global.Fixes flutter/flutter#117195
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.