[webview_flutter_android] Adds support for selecting Hybrid Composition #6864
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
p: webview_flutter
bparrishMines
changed the title
| /// an Android SurfaceTexture. See | ||
| /// https://flutter.dev/docs/development/platform-integration/platform-views#performance | ||
| /// https://github.com/flutter/flutter/issues/104889, | ||
| /// https://github.com/flutter/flutter/issues/104889. |
There was a problem hiding this comment.
These two are the same link.
There was a problem hiding this comment.
Whoops. That one is supposed to be flutter/flutter#116954. Updated.
| SystemChannels.platform_views.setMockMethodCallHandler( | ||
| (MethodCall call) async { | ||
| methodChannelLog.add(call); | ||
| if (call.method == 'resize') { |
There was a problem hiding this comment.
This is quite fragile, since it relies on internal implementation details of the framework. Couldn't we do a trivial wrapper around PlatformViewsService and allow injecting a trivial mock for that wrapper instead?
There was a problem hiding this comment.
Thats a good suggestion since we already do this with the AndroidProxy. done
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM once legacy analyze is happy (maybe 3.0 needs an extra import for that type?)
bparrishMines
added
the
autosubmit
* c61ac23fc [webview_flutter_wkwebview] Adds support for `WKNavigationAction.navigationType` (flutter/plugins#6863) * 15cfe8aa2 [webview_flutter_android] Adds support for selecting Hybrid Composition (flutter/plugins#6864) * 2dd85ec81 [webview_flutter_android] Fixes bug where a `AndroidNavigationDelegate` was required to load a request (flutter/plugins#6872)
…#117535) * c61ac23fc [webview_flutter_wkwebview] Adds support for `WKNavigationAction.navigationType` (flutter/plugins#6863) * 15cfe8aa2 [webview_flutter_android] Adds support for selecting Hybrid Composition (flutter/plugins#6864) * 2dd85ec81 [webview_flutter_android] Fixes bug where a `AndroidNavigationDelegate` was required to load a request (flutter/plugins#6872)
…#117535) * c61ac23fc [webview_flutter_wkwebview] Adds support for `WKNavigationAction.navigationType` (flutter/plugins#6863) * 15cfe8aa2 [webview_flutter_android] Adds support for selecting Hybrid Composition (flutter/plugins#6864) * 2dd85ec81 [webview_flutter_android] Fixes bug where a `AndroidNavigationDelegate` was required to load a request (flutter/plugins#6872)
…on (flutter#6864) * add displayWithHybridComposition flag * move duplicate method * unit tests * adds * update docs * create platformviewsserviceproxy * use proxy for platformviewsservice * remove usused code * update display mode * use clever imports
2 participants
Work around for flutter/flutter#104889
Fixes flutter/flutter#108106
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.