This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[video_player] Fix aspect ratio #690
[video_player] Fix aspect ratio #690
Changes from 45 commits
3dd5099
bb8e0b5
f385849
7943a8f
9a7a974
230c7e0
0332538
7ef3092
27f55da
2238d06
9e74b42
d0ecc95
f390cc2
fd5c298
f0ade3c
c55c5c2
65e19ff
0943513
ed6de31
0490800
9b21739
10df65e
57a6540
fcafe84
a57cf89
7796db7
291ff1e
74b5d76
8740483
a9cf432
42ad92f
96afebc
9d7f57c
4be9e38
3cba0f6
6e2d195
9b622ed
de58514
a0d2b25
664aab7
b5b87e8
d589ee5
7e265a5
232fec9
8d571fb
6792cd9
40f756c
055cb53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we calling setState empty here? Can we either move the lines above this to the closure for setState, or comment on the unusual use of setState here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move them inside the setState. We need setState as otherwise the play/pause button UI does not get updated.