Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] Adding support for FirebaseUser.unlink(providerId) #703

Closed
wants to merge 3 commits into from
Closed

[firebase_auth] Adding support for FirebaseUser.unlink(providerId) #703

wants to merge 3 commits into from

Conversation

ko2ic
Copy link
Contributor

@ko2ic ko2ic commented Aug 3, 2018 •
edited
Loading

  • Unlink an auth provider from a user account

@tshedor tshedor mentioned this pull request Sep 5, 2018
Merged
@slightfoot slightfoot mentioned this pull request Sep 10, 2018
Merged
@ko2ic ko2ic force-pushed the firebase_auth_unlink branch 2 times, most recently from 9848f11 to 27dcdd9 Compare September 14, 2018 09:37
@ko2ic ko2ic mentioned this pull request Sep 14, 2018
Merged
@ko2ic
Copy link
Contributor Author

ko2ic commented Sep 14, 2018

The difference from #775 is whether the method is divided for each Provider or whether to supply ProviderId as argument.
(Other differences are here, PR of one modification.)
If it is better to separate the method for each provider, we will fix it.

@kroikie
Copy link
Contributor

kroikie commented Oct 3, 2018

@ko2ic Thanks for this PR, please rebase onto master so that conflicts are resolved. Also could you limit your changes to the unlink feature? If you want to do other edits please submit those in another PR.

@ko2ic
Copy link
Contributor Author

ko2ic commented Oct 4, 2018

Also could you limit your changes to the unlink feature?

Of course. I will do so.

@ko2ic ko2ic force-pushed the firebase_auth_unlink branch 5 times, most recently from 69cd142 to 35da956 Compare October 4, 2018 08:32
@ko2ic
Copy link
Contributor Author

ko2ic commented Oct 4, 2018

@kroikie I changed. Thank you for your review.
Please also review the divided PR. #814

@ko2ic ko2ic force-pushed the firebase_auth_unlink branch 5 times, most recently from 421e62a to 5ada715 Compare October 25, 2018 00:33
@ko2ic ko2ic changed the title Adding support for FirebaseUser.unlink(providerId) [firebase_auth] Adding support for FirebaseUser.unlink(providerId) Nov 1, 2018
@ko2ic ko2ic force-pushed the firebase_auth_unlink branch 2 times, most recently from ecd1c4a to bb14b90 Compare November 8, 2018 01:32
@ko2ic ko2ic force-pushed the firebase_auth_unlink branch from bb14b90 to 9b1eb70 Compare November 9, 2018 08:20
@kroikie kroikie self-assigned this Nov 9, 2018
kroikie
kroikie suggested changes Nov 10, 2018
View reviewed changes
packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m Outdated
@@ -227,6 +237,10 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
completion:^(NSError *error) {
[self sendResult:result forUser:nil error:error];
}];
[[FIRAuth auth].currentUser updatePassword:password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we handle this in another PR. Removing this and only handling unlink in this PR. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.
Could you review again?

Copy link
Contributor Author

@ko2ic ko2ic Nov 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may not know the change point with force push.
The changed point is two.

  • I fixed it to handle only unlink.
  • [FIRAuth auth] -> [self getAuth:call.arguments] in unlink.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroikie : I want to use this unlink function. Could you review this pull request as soon as possible?

@ko2ic ko2ic force-pushed the firebase_auth_unlink branch 2 times, most recently from 5f5021a to 72f809b Compare November 16, 2018 01:13
@ko2ic ko2ic force-pushed the firebase_auth_unlink branch from 72f809b to 85e9f76 Compare November 20, 2018 01:41
@ko2ic ko2ic force-pushed the firebase_auth_unlink branch 3 times, most recently from bf33539 to a5d42fa Compare November 20, 2018 06:49
@ko2ic ko2ic force-pushed the firebase_auth_unlink branch from 299aeaf to 021f770 Compare November 21, 2018 00:37
@ko2ic
Copy link
Contributor Author

ko2ic commented Nov 21, 2018

@kroikie Conflict resolved.
Merge is now available.

@kroikie
Copy link
Contributor

kroikie commented Nov 21, 2018

@ko2ic please bump version to 0.6.7

@ko2ic ko2ic force-pushed the firebase_auth_unlink branch from a09ebb0 to cdde055 Compare November 21, 2018 01:57
@ko2ic
Copy link
Contributor Author

ko2ic commented Nov 21, 2018

@kroikie I did it.

@ko2ic ko2ic deleted the firebase_auth_unlink branch November 22, 2018 00:21
@ko2ic ko2ic restored the firebase_auth_unlink branch November 22, 2018 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manhnhhdvn manhnhhdvn manhnhhdvn left review comments

@kroikie kroikie kroikie approved these changes

Assignees

@kroikie kroikie

Labels
cla: yes flutterfire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ko2ic @kroikie @manhnhhdvn @googlebot