Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_android] Fixes initial padding not working while map has not been created yet. #7135

Merged
merged 9 commits into from
Feb 14, 2023

Conversation

balvinderz
Copy link
Contributor

[google_maps_flutter_android] Fixes initial padding not working while map has not been created yet.

flutter/flutter#43721

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@balvinderz
Copy link
Contributor Author

@reidbaker Can you please review this.

@reidbaker reidbaker requested review from reidbaker and removed request for GaryQian February 9, 2023 15:49
@reidbaker reidbaker requested a review from camsim99 February 9, 2023 15:53
@balvinderz balvinderz requested review from reidbaker and removed request for camsim99 February 9, 2023 16:00
@reidbaker reidbaker requested a review from camsim99 February 9, 2023 16:20
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2023
@auto-submit auto-submit bot merged commit 7a7e43e into flutter:main Feb 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 15, 2023
* 66d5724fa Revert "[camera] flip/change camera while recording (split out PR for cam_avfoundation and cam_android) (#7109)" (flutter/plugins#7181)

* d2fba3822 [webview_flutter_android][webview_flutter_wkwebview] Adds support to retrieve native `WebView` (flutter/plugins#7071)

* 7a7e43e79 [google_maps_flutter_android] Fixes initial padding not working while map has not been created yet. (flutter/plugins#7135)

* 677b43ad9 [ci] Remove repo tooling (flutter/plugins#7172)

* 2ce625f1a [cameraX] Add integration test for availableCameras (flutter/plugins#7156)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants