Fix version conflicts, verify publishability of packages in CI, Remove Travis #729
Conversation
gspencergoog
force-pushed
the
update_versions
branch
2 times, most recently
from
0966387 to
1ff151c
Compare
|
Thank you for this Greg. I started going down this path today just to fix the analyzer and build errors. I will close my PR. |
|
It also seems like a package sneaked in (MLExample) that does not even build for iOS. |
|
Hmm, yes, I see what you mean. Hey @bparrishMines, does that iOS example compile for you? Could you take a look and give me a patch if needed? (I don't really know much about building iOS apps). I'm trying to get the plugins repo to the point that it all builds... |
gspencergoog
force-pushed
the
update_versions
branch
3 times, most recently
from
2996d16 to
42ee552
Compare
|
I think the iOS problem is fixed now that I synced to master branch HEAD again. Now if I could get the apk build to finish before the gradle daemon crashes... |
gspencergoog
force-pushed
the
update_versions
branch
3 times, most recently
from
d8876b5 to
fc80e0b
Compare
gspencergoog
force-pushed
the
update_versions
branch
from
fc80e0b to
0dcc9b1
Compare
gspencergoog
changed the title
|
I also had to bump the Cirrus instance memory requirements from the default (4G?) to 8G, because the sensors example kept running out of memory and crashing during the gradle step. |
|
Sorry there's so much stuff in this PR: I tried splitting out the continuous integration stuff to another PR, but the repo won't build without the CI changes, and the CI stuff won't build without the package changes... |
|
@mehmetf could you review this for me, please? |
script/check_publish.sh
Outdated
| return "${#failures[@]}" | ||
| } | ||
|
|
||
| function check_changed_packages() { |
There was a problem hiding this comment.
It seems that we repeat this function. Perhaps define a common script and include it using source?
gspencergoog
force-pushed
the
update_versions
branch
from
3b0636b to
309cb6b
Compare
gspencergoog
force-pushed
the
update_versions
branch
from
309cb6b to
549c7af
Compare
…e Travis (flutter#729) This fixes a number of version resolution errors that would prevent these packages from building, and turn off Travis, since Cirrus now works. I also fixed a number of errors that would have prevented these packages from being published without warnings, and establishes a CI script that will verify publishability for any changed packages in a PR. For some examples, we were depending upon versions of other 1st-party plugins by using path: ../../<package>, which really isn't the right way to do things, so for those examples, they now depend on a published version. I bumped the version number of any packages that were modified, and updated their CHANGELOGs since the dependencies have changed. Also fixed a number of analyzer errors that somehow snuck in.
…e Travis (flutter#729) This fixes a number of version resolution errors that would prevent these packages from building, and turn off Travis, since Cirrus now works. I also fixed a number of errors that would have prevented these packages from being published without warnings, and establishes a CI script that will verify publishability for any changed packages in a PR. For some examples, we were depending upon versions of other 1st-party plugins by using path: ../../<package>, which really isn't the right way to do things, so for those examples, they now depend on a published version. I bumped the version number of any packages that were modified, and updated their CHANGELOGs since the dependencies have changed. Also fixed a number of analyzer errors that somehow snuck in.
This fixes a number of version resolution errors that would prevent these packages from building, and turn off Travis, since Cirrus now works.
I also fixed a number of errors that would have prevented these packages from being published without warnings, and establishes a CI script that will verify publishability for any changed packages in a PR.
For some examples, we were depending upon versions of other 1st-party plugins by using
path: ../../<package>, which really isn't the right way to do things, so for those examples, they now depend on a published version.I bumped the version number of any packages that were modified, and updated their CHANGELOGs since the dependencies have changed.
Also fixed a number of analyzer errors that somehow snuck in.