-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Port google_maps_flutter to use AndroidView for embedding the map. #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change adds a GoogleMap widget which shows a map as part of the widget tree. Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps$id', The Java GoogleMapsController class now extends PlatformView, and is the Java endpoint of the per map method channel. This change disables the plugin on iOS until we have an inlining solution for iOS.
1667e35
to
d343a6b
Compare
d343a6b
to
efcd8f6
Compare
Thanks for the review, will land on green. |
* upstream/master: Update FOSDC config (flutter#751) Add support-v4 dep to ml-vision (flutter#750) Add support for firebaseopensource.com (flutter#749) Use api to allow support-v4 version resolution. (flutter#748) Depend on full support-v4 library for ease of use (flutter#747) Plugin template for webview_flutter (flutter#746) Fix Java lint warnings in google maps plugin (flutter#745) Remove iOS instructions from the maps plugin readme. (flutter#744) [image_picker] White line after resize - fixed by adding floor() (flutter#686) Port google_maps_flutter to use AndroidView for embedding the map. (flutter#743)
So i have tried out the example in plugins/google_maps_flutter and ran into some errors, error: no interface expected here anyone managed to run this cleanly? |
This uses features that are currently only available on the Flutter master
channel.
…On Fri, Aug 31, 2018, 2:04 AM tiagofalves ***@***.***> wrote:
So i have tried out the example in plugins/google_maps_flutter and ran
into some errors,
error: no interface expected here
error: incompatible types: GoogleMapFactory cannot be converted to
PlatformViewFactory
anyone managed to run this cleanly?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#743 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA-gdXVUstEuI5NQDtMwSiDCaFyTSaolks5uWPwZgaJpZM4WOZp9>
.
|
Thanks for the heads up |
Hi @amirh, got another issue. When i use a map in a tab the map controller doesn't seem to be receiving the swipe commands... Is there any way of overlapping the map controller on the tab controller that i am unware of? This is not a big issue, its just something i came across... |
Check the example in #755
…On Sat, Sep 1, 2018, 2:57 AM tiagofalves ***@***.***> wrote:
Hi @amirh <https://github.com/amirh>, got another issue. When i use a map
in a tab the map controller doesn't seem to be receiving the swipe
commands... Is there any way of overlapping the map controller on the tab
controller that i am unware of? This is not a big issue, its just something
i came across...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#743 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA-gdU5MEoFcpDxGur8psvitXmbOh4B7ks5uWlntgaJpZM4WOZp9>
.
|
@tiagofalves Make sure you are doing like in the example of using navigatorObservers https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/example/lib/main.dart (IMO not that practical since it requires you to create your widget in advance) or else do something like activating and deactivating the overlays. I have an example here: https://github.com/gerryhigh/Flutter-Google-Maps-Demo/blob/master/lib/venues.dart |
This is no longer used since flutter#743, the empty list was just a left over.
This is no longer used since #743, the empty list was just a left over.
…lutter#743) This change adds a GoogleMap widget which shows a map as part of the widget tree. Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps_$id', The Java GoogleMapsController class now extends PlatformView, and is the Java endpoint of the per map method channel. This change disables the plugin on iOS until we have an inlining solution for iOS.
…er#763) This is no longer used since flutter#743, the empty list was just a left over.
…lutter#743) This change adds a GoogleMap widget which shows a map as part of the widget tree. Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps_$id', The Java GoogleMapsController class now extends PlatformView, and is the Java endpoint of the per map method channel. This change disables the plugin on iOS until we have an inlining solution for iOS.
…er#763) This is no longer used since flutter#743, the empty list was just a left over.
… map. (flutter#743)" This reverts commit f90b93f.
This change adds a GoogleMap widget which shows a map as part of the widget tree.
Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps_$id',
The Java GoogleMapsController class now extends PlatformView, and is the
Java endpoint of the per map method channel.
This change disables the plugin on iOS until we have an inlining solution
for iOS.
flutter/flutter#73