Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Port google_maps_flutter to use AndroidView for embedding the map. #743

Merged
merged 4 commits into from
Aug 29, 2018

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Aug 27, 2018

This change adds a GoogleMap widget which shows a map as part of the widget tree.
Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps_$id',
The Java GoogleMapsController class now extends PlatformView, and is the
Java endpoint of the per map method channel.

This change disables the plugin on iOS until we have an inlining solution
for iOS.

flutter/flutter#73

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amirh added 3 commits August 29, 2018 08:49
This change adds a GoogleMap widget which shows a map as part of the  widget tree.
Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps$id',
The Java GoogleMapsController class now extends PlatformView, and is the
Java endpoint of the per map method channel.

This change disables the plugin on iOS until we have an inlining solution
for iOS.
@amirh amirh force-pushed the embedded_maps_android branch 3 times, most recently from 1667e35 to d343a6b Compare August 29, 2018 16:29
@amirh amirh force-pushed the embedded_maps_android branch from d343a6b to efcd8f6 Compare August 29, 2018 16:30
@amirh
Copy link
Contributor Author

amirh commented Aug 29, 2018

Thanks for the review, will land on green.

@amirh amirh merged commit e5cb1a5 into flutter:master Aug 29, 2018
@amirh amirh deleted the embedded_maps_android branch August 29, 2018 16:48
teriyakijack added a commit to teriyakijack/plugins that referenced this pull request Aug 31, 2018
* upstream/master:
  Update FOSDC config (flutter#751)
  Add support-v4 dep to ml-vision (flutter#750)
  Add support for firebaseopensource.com (flutter#749)
  Use api to allow support-v4 version resolution. (flutter#748)
  Depend on full support-v4 library for ease of use (flutter#747)
  Plugin template for webview_flutter (flutter#746)
  Fix Java lint warnings in google maps plugin (flutter#745)
  Remove iOS instructions from the maps plugin readme. (flutter#744)
  [image_picker] White line after resize - fixed by adding floor() (flutter#686)
  Port google_maps_flutter to use AndroidView for embedding the map. (flutter#743)
@tiagofalves
Copy link

So i have tried out the example in plugins/google_maps_flutter and ran into some errors,

error: no interface expected here
error: incompatible types: GoogleMapFactory cannot be converted to PlatformViewFactory

anyone managed to run this cleanly?

@amirh
Copy link
Contributor Author

amirh commented Aug 31, 2018 via email

@tiagofalves
Copy link

Thanks for the heads up

@tiagofalves
Copy link

Hi @amirh, got another issue. When i use a map in a tab the map controller doesn't seem to be receiving the swipe commands... Is there any way of overlapping the map controller on the tab controller that i am unware of? This is not a big issue, its just something i came across...

@amirh
Copy link
Contributor Author

amirh commented Sep 1, 2018 via email

@gerryhigh
Copy link
Contributor

@tiagofalves Make sure you are doing like in the example of using navigatorObservers https://github.com/flutter/plugins/blob/master/packages/google_maps_flutter/example/lib/main.dart (IMO not that practical since it requires you to create your widget in advance) or else do something like activating and deactivating the overlays. I have an example here: https://github.com/gerryhigh/Flutter-Google-Maps-Demo/blob/master/lib/venues.dart

amirh added a commit to amirh/plugins that referenced this pull request Sep 5, 2018
This is no longer used since flutter#743, the empty list was just a
left over.
amirh added a commit that referenced this pull request Sep 5, 2018
This is no longer used since #743, the empty list was just a
left over.
nichtverstehen pushed a commit to nichtverstehen/plugins that referenced this pull request Sep 6, 2018
…lutter#743)

This change adds a GoogleMap widget which shows a map as part of the  widget tree.
Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps_$id',
The Java GoogleMapsController class now extends PlatformView, and is the
Java endpoint of the per map method channel.

This change disables the plugin on iOS until we have an inlining solution
for iOS.
nichtverstehen pushed a commit to nichtverstehen/plugins that referenced this pull request Sep 6, 2018
…er#763)

This is no longer used since flutter#743, the empty list was just a
left over.
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
…lutter#743)

This change adds a GoogleMap widget which shows a map as part of the  widget tree.
Each map uses a dedicated method channel named 'plugins.flutter.io/google_maps_$id',
The Java GoogleMapsController class now extends PlatformView, and is the
Java endpoint of the per map method channel.

This change disables the plugin on iOS until we have an inlining solution
for iOS.
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
…er#763)

This is no longer used since flutter#743, the empty list was just a
left over.
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants