Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

FirebaseAuth multi app support #781

Merged
merged 22 commits into from
Oct 22, 2018
Merged

FirebaseAuth multi app support #781

merged 22 commits into from
Oct 22, 2018

Conversation

matthewtsmith
Copy link
Contributor

This adds support for allowing the FirebaseAuth package to connect to multiple firebase instances.

@matthewtsmith
Multi app support
333ae0e
@matthewtsmith
Android support
194ac78
@matthewtsmith
Remove unused method
cf443f5
@matthewtsmith
upgrade auth dep
a622f9c
@matthewtsmith
Merge remote-tracking branch 'remotes/flutter/master'
2b00937 
# Conflicts:
#	packages/firebase_auth/android/build.gradle
#	packages/firebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java
#	packages/firebase_auth/lib/firebase_auth.dart
@matthewtsmith
Add multi app support for new auth methods
2d1eee9
@matthewtsmith
run formatter
9ab64e5
@matthewtsmith
Run objc formatter
5a57eb8
@matthewtsmith
Fix dart fmt
0482385
@matthewtsmith
Merge remote-tracking branch 'flutter/master'
d741e48 
# Conflicts:
#	packages/firebase_auth/example/lib/main.dart
#	packages/firebase_auth/lib/firebase_auth.dart
@matthewtsmith
fix conflicts from flutter/master
cc3784c
@OscarEReyes
Copy link

Hi, is this tackling the issue of FirebaseAuth not handling non-default apps?

@matthewtsmith
Copy link
Contributor Author

@OscarEReyes yes

@kroikie kroikie requested a review from bparrishMines October 15, 2018 18:47
@bparrishMines bparrishMines self-assigned this Oct 15, 2018
Matthew Smith and others added 7 commits October 16, 2018 08:02
Merge remote-tracking branch 'flutter/master'
e69686f 
# Conflicts:
#	packages/firebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java
#	packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m
#	packages/firebase_auth/lib/firebase_auth.dart
@matthewtsmith
Updated calls to use multi app support
9357ea1 
updated firebase_core dependency
@matthewtsmith
Running formatter
708d469
@matthewtsmith
linter
114721a
@matthewtsmith
Fix tests
609bc1a
@matthewtsmith
Try more clang formatting
3d6bb6e
@matthewtsmith
sort constructors
c57cc8e
@matthewtsmith
Copy link
Contributor Author

@bparrishMines I'm struggling to get the test+format to pass. It's complaining about the Objective-C formatting. I've run pub global run flutter_plugin_tools format which formats my code successfully but it is still not accepting the change. Can you provide some on what to do to fix this? https://github.com/flutter/plugins/pull/781/checks?check_run_id=24385906

@bparrishMines
Copy link
Contributor

bparrishMines commented Oct 19, 2018 •
edited
Loading

Hi @matthewtsmith,

I think you may being having an issue with your version of clang-format. Our analyzer uses version 5.0. You may have to switch to that version to get the correct formatting. This link should help.

If that doesn't work, you can also click on details of the test+format test and make the formatting changes by hand. I would click on the second details link if you choose to go with this one. (It's color coded).

@matthewtsmith
Copy link
Contributor Author

@bparrishMines That looks like the problem, I was on Clang 8. Thanks for the help.

bparrishMines
bparrishMines approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for the delay of the review and thanks for the contribution!
I'll create and link PR that bumps version.

@bparrishMines bparrishMines merged commit 50e2ec8 into flutter:master Oct 22, 2018
This was referenced Oct 22, 2018
Merged
Merged
@NikoYuwono NikoYuwono mentioned this pull request Dec 4, 2018
Closed
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
@matthewtsmith @andreidiaconu
FirebaseAuth multi app support (flutter#781)
93187e6
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
@andreidiaconu
Revert "FirebaseAuth multi app support (flutter#781)"
f9d2951 
This reverts commit 93187e6.
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@matthewtsmith @bparrishMines
FirebaseAuth multi app support (flutter#781)
819b2bc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

Assignees

@bparrishMines bparrishMines

Labels
cla: yes flutterfire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewtsmith @OscarEReyes @bparrishMines @googlebot