Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

fix CI #825

Merged
merged 1 commit into from
Oct 8, 2018
Merged

fix CI #825

merged 1 commit into from
Oct 8, 2018

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Oct 8, 2018

No description provided.

@a14n
Copy link
Contributor Author

a14n commented Oct 8, 2018

The issues were caused by a fix in sort_constructors_first and an other fix on unnecessary_this.

@a14n
Copy link
Contributor Author

a14n commented Oct 8, 2018

The CI is still failing but not because of Dart code. Now it's because of some APK build failures because of java dependency issue:

  • cloud_firestore/example (apk)
  • cloud_functions/example (apk)
  • firebase_database/example (apk)
  • firebase_storage/example (apk)
FAILURE: Build failed with an exception.
* What went wrong:
Failed to capture snapshot of input files for task ':app:preReleaseBuild' property 'compileManifests' during up-to-date check.
> The library com.google.android.gms:play-services-basement is being requested by various other libraries at [[15.0.1,15.0.1]], but resolves to 16.0.1. Disable the plugin and check your dependencies tree using ./gradlew :app:dependencies.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 6s
 6.7s
Gradle task assembleRelease failed with exit code 1

@a14n
Copy link
Contributor Author

a14n commented Oct 8, 2018

I think we can land this PR (sorry but I don't have time to dig into those new errors)

@mit-mit
Copy link
Member

mit-mit commented Oct 8, 2018

cc @cbracken @kroikie

@cbracken cbracken merged commit a6a469a into flutter:master Oct 8, 2018
@cbracken
Copy link
Member

cbracken commented Oct 8, 2018

Thanks Alexandre! LGTM.

@a14n a14n deleted the fix-CI branch October 8, 2018 20:01
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants