Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Reconfigure Cirrus to use clang 7 #905

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Nov 19, 2018

clang-format 5.0 formats ObjC files differently than newer versions, which results in the CI failing the format check for PRs formatted locally with a recent clang version.

The latest clang version available on the Ubuntu repositories for the Cirrus machines is 7, upgrading to that seems to be consistent with what I locally get with clang-format 8.0.

This PR also reformats all files with the new clang style.

@amirh amirh changed the title Reconfigure Cirrus to use clang 8.0 Reconfigure Cirrus to use clang 7 Nov 19, 2018
@amirh amirh merged commit eaa1388 into flutter:master Nov 20, 2018
@amirh amirh deleted the cirrus_clang_8 branch November 20, 2018 00:30
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
clang-format 5.0 formats ObjC files differently than newer versions, which results in the CI failing the format check for PRs formatted locally with a recent clang version.

The latest clang version available on the Ubuntu repositories for the Cirrus machines is 7, upgrading to that seems to be consistent with what I locally get with clang-format 8.0.

This PR also reformats all files with the new clang style.
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
clang-format 5.0 formats ObjC files differently than newer versions, which results in the CI failing the format check for PRs formatted locally with a recent clang version.

The latest clang version available on the Ubuntu repositories for the Cirrus machines is 7, upgrading to that seems to be consistent with what I locally get with clang-format 8.0.

This PR also reformats all files with the new clang style.
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
clang-format 5.0 formats ObjC files differently than newer versions, which results in the CI failing the format check for PRs formatted locally with a recent clang version.

The latest clang version available on the Ubuntu repositories for the Cirrus machines is 7, upgrading to that seems to be consistent with what I locally get with clang-format 8.0.

This PR also reformats all files with the new clang style.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants