Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simplistic_editor for Flutter 3.4 beta #1447

Closed
wants to merge 0 commits into from
Closed

Update simplistic_editor for Flutter 3.4 beta #1447

wants to merge 0 commits into from

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Sep 27, 2022 •
edited
Loading

This PR updates simplistic_editor for Flutter 3.4 beta.

Fixes #1443

Pre-launch Checklist

  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

@domesticmouse
Copy link
Contributor

Please re-enable beta and master CI:

domesticmouse
domesticmouse approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is re-enabled

Renzo-Olivares
Renzo-Olivares approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@bleroux
Copy link
Contributor Author

bleroux commented Sep 28, 2022

LGTM once CI is re-enabled

@domesticmouse Thanks for the review and the tip about re-enabling CI. 👍
As this code fails on stable channel, can you explain me the expected process on flutter/samples for merging this PR? Do we have to wait for the next Flutter stable release before merging?

@bleroux bleroux mentioned this pull request Sep 28, 2022
Closed
@domesticmouse
Copy link
Contributor

LGTM once CI is re-enabled

@domesticmouse Thanks for the review and the tip about re-enabling CI. 👍

As this code fails on stable channel, can you explain me the expected process on flutter/samples for merging this PR? Do we have to wait for the next Flutter stable release before merging?

Yup, this PR will hang here until we have a new stable. I'll handle rolling this into a beta branch and then into stable.

@domesticmouse domesticmouse mentioned this pull request Oct 2, 2022
Closed
@bleroux bleroux mentioned this pull request Oct 5, 2022
Merged
@domesticmouse
Copy link
Contributor

Can you please update this PR, or give me access to do so? It has conflicts =(

@bleroux bleroux force-pushed the Update_simplistic_editor_to_flutter_3.4 branch from 739d44f to 6d41f95 Compare October 10, 2022 06:31
@bleroux
Copy link
Contributor Author

bleroux commented Oct 10, 2022

Can you please update this PR, or give me access to do so? It has conflicts =(

I have updated the PR. FYI, I disabled master channel CI because there is a new breaking change in master and this PR is targeting beta channel.

@Renzo-Olivares Renzo-Olivares mentioned this pull request Nov 11, 2022
Closed
@domesticmouse
Copy link
Contributor

Please merge the latest from main. I'm preparing for a beta uber PR that this would be rolled into.

@domesticmouse
Copy link
Contributor

Integrated into #1556

@bleroux bleroux force-pushed the Update_simplistic_editor_to_flutter_3.4 branch from 6d41f95 to 7b07798 Compare January 10, 2023 08:53
@bleroux
Copy link
Contributor Author

bleroux commented Jan 10, 2023 •
edited
Loading

I have rebased this PR and updated it to comply with flutter/flutter#76072 (add an implementation for TextInputClient.didChangeInputControl).
I have also renabled CI on master because beta and master are aligned now.

@bleroux
Copy link
Contributor Author

bleroux commented Jan 10, 2023

@domesticmouse This PR should be ok now on beta and master.

@domesticmouse
Copy link
Contributor

Thank you, re-integrated into #1556 and now everything is green on beta and master. =)

@domesticmouse
Copy link
Contributor

This should now be closeable. To be sure, please resolve conflicts and you should hopefully see this PR resolve to 0 files changed.

@bleroux bleroux closed this Jan 25, 2023
@bleroux bleroux force-pushed the Update_simplistic_editor_to_flutter_3.4 branch from 4ccc9fb to 294ea4f Compare January 25, 2023 07:38
@bleroux
Copy link
Contributor Author

bleroux commented Jan 25, 2023

This should now be closeable. To be sure, please resolve conflicts and you should hopefully see this PR resolve to 0 files changed.

Great! Happy that those changes were useful 👍

@bleroux bleroux deleted the Update_simplistic_editor_to_flutter_3.4 branch January 25, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simplistic_editor needs update for Flutter 3.4 beta
3 participants
@bleroux @domesticmouse @Renzo-Olivares