Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the commit for flutter_gallery.test #198

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

srawlins
Copy link
Contributor

This commit includes flutter/gallery#844 which is required for Dart 3.

Work towards dart-lang/sdk#50751

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This commit includes flutter/gallery#844 which is required for Dart 3.

Work towards dart-lang/sdk#50751
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

@srawlins Looks like there is a failing check.

@srawlins
Copy link
Contributor Author

srawlins commented Jan 4, 2023

What's the process here? I don't know which line out of thousands of stdout is the culprit. If there is a problem between commits d67a02e6566b31dc346891c93ba22b2366a9fb80 and a763dbcce717b9added18803c95303f0615c9d28, do we create an issue for it? This is blocking dart-lang/sdk#47902, fixed in https://dart-review.googlesource.com/c/sdk/+/276766.

@srawlins
Copy link
Contributor Author

srawlins commented Jan 4, 2023

🎉 checks

@srawlins srawlins merged commit c91cd5f into main Jan 4, 2023
@srawlins srawlins deleted the srawlins-patch-6 branch January 4, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants