Skip to content

Conversation

@tsinis
Copy link
Contributor

@tsinis tsinis commented Dec 14, 2024

Description of what this PR is changing or adding, and why:

This PR adds notes about new .gitignore entries for those who want to migrate their old packages to SPM.

Issues fixed by this PR (if any):

Without this step - the guide suggests "Commit your plugin's changes to your version control system" with those .build/ and .swiftpm/ directories newly created in previous steps.

PRs or commits this PR depends on (if any):

flutter/packages#6705

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@tsinis tsinis requested review from a team, parlough and sfshaza2 as code owners December 14, 2024 20:04
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but please weigh in, @loic-sharma.

@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2 sfshaza2 closed this Dec 15, 2024
@sfshaza2 sfshaza2 reopened this Dec 15, 2024
@sfshaza2
Copy link
Contributor

/gcbrun

(Didn't mean to close it!).

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit c1d4931):

https://flutter-docs-prod--pr11497-patch-1-lcfxgrky.web.app

@sfshaza2
Copy link
Contributor

Loic is on vacay, so landing.

@sfshaza2 sfshaza2 merged commit 9c72344 into flutter:main Dec 16, 2024
15 checks passed
@tsinis tsinis deleted the patch-1 branch December 17, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants