-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add stepper component for FWE #12675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a new, highly accessible Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new stepper component, which is a great addition for guided tutorials. The implementation is solid, using <details> for accessibility and providing a client-side script for interactivity. I've left a few suggestions to improve the SCSS styling and enhance accessibility for screen reader users. Overall, great work on this new feature.
| &:last-child::before { | ||
| transform: none; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vertical line connecting steps should not be visible for the last step. Using transform: none; resets the vertical translation but still renders the line, causing it to overlap with the step number. To hide the line for the last step, you should use display: none; instead.
| &:last-child::before { | |
| transform: none; | |
| } | |
| &:last-child::before { | |
| display: none; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should, to still provide a border for the content. Wdyt @parlough?
|
Visit the preview URL for this PR (updated for commit b15845e): https://flutter-docs-prod--pr12675-feat-stepper-component-tgbjxrr9.web.app |
9597a29 to
14db02d
Compare
ce0d21b to
e056473
Compare
e056473 to
b15845e
Compare
Adds a stepper component for FWE.
<details>object, so it's fully accessible and keyboard controllable.Presubmit checklist
of 80 characters or fewer.