-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add CodePreview component #12731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodePreview component #12731
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new CodePreview component to replace the old code_and_image partial, which is a great improvement for consistency and maintainability. The implementation looks solid, and the refactoring across the markdown files is well-executed.
I've found a couple of issues:
- A high-severity bug in the new
CodePreviewcomponent where a component attribute is being read with the wrong case, which will prevent it from working as expected. - A medium-severity theming issue where a hardcoded color is used, which will cause problems in dark mode.
- A medium-severity accessibility issue with incorrect
alttext for an image in one of the updated markdown files.
After addressing these points, the PR should be in excellent shape.
69376fa to
db7861c
Compare
|
Visit the preview URL for this PR (updated for commit e5d3bf3): https://flutter-docs-prod--pr12731-feat-code-preview-component-r7393xt0.web.app |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love love it, much better than I imaged.
Thanks for including the row/col support and the previewcolor is a good idea too.
db7861c to
e5d3bf3
Compare
Adds a new
CodePreviewcomponent to replace usages of thecode_and_imagepartial.Fixes: #12727