-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add DownloadableSnippet component #12733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for interacting with code examples on the site by introducing a versatile Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new SnippetDownloadButton component, which is a great enhancement for user experience, allowing users to download, copy, or open code snippets in a new tab. The implementation is well-structured, using a server-side component to fetch the snippet and a client-side component for the user interactions. I've identified a potential memory leak in the client-side component and a minor code clarity issue in the server-side component. My detailed feedback and suggestions for improvement are provided in the comments below.
site/lib/src/components/tutorial/client/file_download_button.dart
Outdated
Show resolved
Hide resolved
c6c73d1 to
59cb69c
Compare
|
Visit the preview URL for this PR (updated for commit 1b1e2ec): https://flutter-docs-prod--pr12733-feat-download-code-button-id2rvwh2.web.app |
site/lib/src/components/tutorial/client/file_download_button.dart
Outdated
Show resolved
Hide resolved
0fb2c19 to
c202b44
Compare
c202b44 to
1b1e2ec
Compare
|
@parlough This is now updated to be a collapsed code block instead of just a button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect and works well across the browsers I tested. Thanks for making those adjustments @schultek!
Adds a component for downloading a code snippet as a file. This is displayed as a collapsed code block with additional action buttons in the title.
Provides three options:
I also updated the
CopyButtonto extract its content from the actual code element instead of taking it as an parameter, to avoid duplicating the data in the output html.