Skip to content

add breaking change for FlutterMain.setIsRunningInRobolectricTest removal #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2020
Merged

add breaking change for FlutterMain.setIsRunningInRobolectricTest removal #4561

merged 3 commits into from
Nov 13, 2020

Conversation

@xster
Copy link
Member

@xster xster commented Aug 31, 2020

No description provided.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Aug 31, 2020
@ditman
Copy link
Member

ditman commented Aug 31, 2020

Thanks for documenting this!

@xster xster mentioned this pull request Sep 1, 2020
Merged
sfshaza2
sfshaza2 requested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a small error that could explain the breaking build (though I had already kicked it off again).

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 3, 2020

@domesticmouse, @johnpryan, could one of you take a look at this? This PR is breaking the build. Ive crawled through the output file. It's breaking on the link check, but I don't see why. The output file shows lots of redirects (301s that resolve to 200s), which is fine, but no 404s.

sfshaza2
sfshaza2 reviewed Sep 3, 2020
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we figure out the bad link, this LGTM

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 10, 2020

@johnpryan, can you take a look at why this PR is breaking the build? It's not clear to me.

@xster, we now have a file conflict. As often happens as PRs age. :). Please fix.

@xster xster force-pushed the robolectric-deprecation branch from 37398e3 to d593526 Compare September 10, 2020 06:54
@xster
Copy link
Member Author

xster commented Sep 10, 2020

Updated. Mehmet's doc has a dangling link. Removed too.

johnpryan
johnpryan reviewed Sep 11, 2020
View reviewed changes
src/docs/release/breaking-changes/index.md Outdated
[The new Form, FormField auto-validation API]: /docs/release/breaking-changes/form-field-autovalidation-api
<!-- Re-enable once HTTP ban lands to flutter/flutter -->
<!-- [Network Policy on iOS and Android]: /docs/release/breaking-changes/network-policy-ios-android -->
[Android FlutterMain.setIsRunningInRobolectricTest testing API removed]: /docs/release/breaking-change/android-setIsRunningInRobolectricTest-removed
Copy link
Contributor

@johnpryan johnpryan Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be breaking-changes instead of breaking-change I think, which is why the linkcheck tool is failing.

Copy link
Member Author

@xster xster Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! 🤦🏻‍♂️
Thanks John

@xster xster force-pushed the robolectric-deprecation branch from 5bd8904 to 011c289 Compare September 17, 2020 15:48
@xster xster requested a review from sfshaza2 September 18, 2020 17:54
@xster xster mentioned this pull request Sep 18, 2020
Merged
@dnfield
Copy link
Contributor

dnfield commented Sep 22, 2020

This is changing slightly again with flutter/engine#20473 so I made some additional tweaks if anyone can check.

@xster
Copy link
Member Author

xster commented Sep 22, 2020

LGTM. Thanks Dan

@xster xster force-pushed the robolectric-deprecation branch from 301b89b to 1b44856 Compare October 26, 2020 16:11
@google-cla
Copy link

google-cla bot commented Oct 26, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Contributor has not signed the Contributor License Agreement and removed cla: yes Contributor has signed the Contributor License Agreement labels Oct 26, 2020
@dnfield
Copy link
Contributor

dnfield commented Oct 26, 2020

@googlebot I consent

@google-cla google-cla bot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Oct 26, 2020
@xster xster marked this pull request as draft October 26, 2020 16:17
@xster
Copy link
Member Author

xster commented Oct 26, 2020

I'm putting this to draft while waiting for flutter/engine#20473 to merge.

sfshaza2
sfshaza2 approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the flutter/flutter change has landed, let's merge this puppy!

@dnfield
Copy link
Contributor

dnfield commented Nov 13, 2020

Upstream changes have finally landed. Sorry for the delay.

sfshaza2
sfshaza2 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2
Copy link
Contributor

sfshaza2 commented Nov 13, 2020

@dnfield, @xster, I was about to merge this PR, but it's still marked as draft.

@xster xster marked this pull request as ready for review November 13, 2020 05:58
@xster xster merged commit 4079126 into flutter:master Nov 13, 2020
@xster xster deleted the robolectric-deprecation branch November 13, 2020 05:59
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
@xster @filiph
add breaking change for FlutterMain.setIsRunningInRobolectricTest rem…
cdd78ed 
…oval (flutter#4561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan left review comments

@sfshaza2 sfshaza2 sfshaza2 approved these changes

+1 more reviewer

@Cc8-ux Cc8-ux Cc8-ux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xster @ditman @sfshaza2 @dnfield @johnpryan @Cc8-ux @googlebot