Skip to content

Conversation

@johnpryan
Copy link
Contributor

@johnpryan johnpryan requested a review from sfshaza2 November 11, 2020 17:58
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Nov 11, 2020
- [redsolver](https://github.com/redsolver) contributed to the [Table docs](https://master-api.flutter.dev/flutter/widgets/Table-class.html) ([pull request](https://github.com/flutter/flutter/pull/69588))
- [tsvillain](https://github.com/tsvillain) contributed to the [Tooltip](https://master-api.flutter.dev/flutter/material/Tooltip-class.html) ([pull request](https://github.com/flutter/flutter/pull/69518))
- [Thesmader](https://github.com/Thesmader) contributed to the [SnackBar](https://master-api.flutter.dev/flutter/material/SnackBar-class.html) ([pull request](https://github.com/flutter/flutter/pull/69555))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnpryan, this looks pretty good, but I feel like it's missing some text. How about adding something like:

Thanks to your eager participation, all of the widgets were assigned in xxx hours and all issues have been addressed, though we are still reviewing PRs. Based on the success of this experiment, we may do something similar in the future, so stay tuned!

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@johnpryan
Copy link
Contributor Author

@sfshaza2 this is ready for another look

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit 3bc9d45 into flutter:master Nov 12, 2020
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
* Update adoptawidget page with list of contributions

* Update message, add additional contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants